kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject incubator-kudu git commit: preflight: require libtoolize on Linux, not libtool
Date Mon, 28 Mar 2016 19:59:38 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master e317be64f -> 457f6fb0d


preflight: require libtoolize on Linux, not libtool

Modern Ubuntu-based distros have split libtool into an architecture
independent package (libtool) and a dependent package (libtool-bin). Only
the former is needed to build thirdparty, and it contains the binary
'libtoolize', not 'libtool', so let's check for that. Older Linux distros
include both, so this change shouldn't affect them.

Change-Id: I590c9fbdc920da100aa3e4a9cd8cca8847569968
Reviewed-on: http://gerrit.cloudera.org:8080/2646
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <todd@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/457f6fb0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/457f6fb0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/457f6fb0

Branch: refs/heads/master
Commit: 457f6fb0d6621dfd007c8c0f022b50606c77b8ec
Parents: e317be6
Author: Adar Dembo <adar@cloudera.com>
Authored: Mon Mar 28 12:25:37 2016 -0700
Committer: Adar Dembo <adar@cloudera.com>
Committed: Mon Mar 28 19:59:10 2016 +0000

----------------------------------------------------------------------
 thirdparty/preflight.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/457f6fb0/thirdparty/preflight.py
----------------------------------------------------------------------
diff --git a/thirdparty/preflight.py b/thirdparty/preflight.py
index cd15f72..5a0b853 100755
--- a/thirdparty/preflight.py
+++ b/thirdparty/preflight.py
@@ -28,6 +28,7 @@ users if they're missing anything obvious.
 """
 
 import os
+import platform
 import sys
 import subprocess
 
@@ -40,7 +41,6 @@ REQUIRED_TOOLS = [
   "automake",
   "curl",
   "git",
-  "libtool",
   "make",
   "patch",
   "pkg-config",
@@ -48,6 +48,14 @@ REQUIRED_TOOLS = [
   "unzip",
   "xxd"]
 
+if platform.system() == "Linux":
+  # Modern Linux distros split libtool functionality into two packages:
+  # libtool-bin (containing 'libtool') and libtool (containing 'libtoolize').
+  # Only the latter is needed for a working autoconf.
+  REQUIRED_TOOLS.append("libtoolize")
+else:
+  REQUIRED_TOOLS.append("libtool")
+
 def log_failure_and_exit(error_msg, exc=None):
   print "***", error_msg
   if exc:


Mime
View raw message