kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject incubator-kudu git commit: KUDU-1336. Fail cmake if gcc <4.8
Date Sun, 20 Mar 2016 20:52:02 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master 90be132b9 -> 8f72630cf


KUDU-1336. Fail cmake if gcc <4.8

Change-Id: I5b64ab456a6e3f03922e32fa0ae72a002c8a11a6
Reviewed-on: http://gerrit.cloudera.org:8080/2451
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <adar@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/8f72630c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/8f72630c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/8f72630c

Branch: refs/heads/master
Commit: 8f72630cfbe6b81a0f156952eb42a14305533839
Parents: 90be132
Author: Todd Lipcon <todd@apache.org>
Authored: Thu Mar 3 21:44:17 2016 -0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Sun Mar 20 20:51:46 2016 +0000

----------------------------------------------------------------------
 CMakeLists.txt | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/8f72630c/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 04cb3fb..b23c1d1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -234,13 +234,11 @@ if ("${COMPILER_FAMILY}" STREQUAL "clang")
     message("Running without a controlling terminal or in a dumb terminal")
   endif()
 elseif("${COMPILER_FAMILY}" STREQUAL "gcc")
-  # Blacklist gcc versions known to generate broken optimized code.
-  #
-  # See KUDU-1030 for more details.
-  if ("${COMPILER_VERSION}" MATCHES "^4.[67]")
-    message(FATAL_ERROR "Building with gcc version ${COMPILER_VERSION} is "
-      "forbidden as it is known to produce broken code in release mode. "
-      "Upgrade gcc, or build with clang from the thirdparty directory.")
+  # Disallow GCC < 4.8, since it doesn't support the C++11 standard
+  # well enough for us.
+  if ("${COMPILER_VERSION}" VERSION_LESS "4.8")
+    message(FATAL_ERROR "GCC <4.8 not supported. Consider using "
+        "thirdparty/clang-toolchain/ to build on older hosts.")
   endif()
 
   # GCC 4.8's tree vectorizer has a bug which causes hard-to-debug incorrect


Mime
View raw message