kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject incubator-kudu git commit: client-test: try to de-flake TestLastErrorEmbeddedInScanTimeoutStatus
Date Wed, 09 Mar 2016 23:03:04 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master 548399849 -> 920e8aa84


client-test: try to de-flake TestLastErrorEmbeddedInScanTimeoutStatus

This test seems to be flaky on the test dashboard, though I couldn't
reproduce it on dist-test (perhaps due to different slave hardware).

Regardless, it seems like there's a race -- we inject 1 second of
latency into the tablet server startup, and then set a 1-second
timeout on our scan. So, maybe our scan can sometimes succeed within
the target time in some cases.

This bumps the latency to 5 seconds to try to make the intended timeout
more of a sure thing.

Change-Id: I63c3e31a737b11ad3c9104d2f77111d17e9a51b7
Reviewed-on: http://gerrit.cloudera.org:8080/2506
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/920e8aa8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/920e8aa8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/920e8aa8

Branch: refs/heads/master
Commit: 920e8aa842a743a24b4c1d4403a0bc162209a367
Parents: 5483998
Author: Todd Lipcon <todd@apache.org>
Authored: Wed Mar 9 14:27:11 2016 -0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Wed Mar 9 22:51:18 2016 +0000

----------------------------------------------------------------------
 src/kudu/client/client-test.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/920e8aa8/src/kudu/client/client-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/client-test.cc b/src/kudu/client/client-test.cc
index 98ceefa..b1fa896 100644
--- a/src/kudu/client/client-test.cc
+++ b/src/kudu/client/client-test.cc
@@ -2723,7 +2723,7 @@ TEST_F(ClientTest, TestLastErrorEmbeddedInScanTimeoutStatus) {
 
     // Restart, but inject latency so that startup is very slow.
     FLAGS_log_inject_latency = true;
-    FLAGS_log_inject_latency_ms_mean = 1000;
+    FLAGS_log_inject_latency_ms_mean = 5000;
     FLAGS_log_inject_latency_ms_stddev = 0;
     for (int i = 0; i < cluster_->num_tablet_servers(); i++) {
       MiniTabletServer* ts = cluster_->mini_tablet_server(i);


Mime
View raw message