kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdcry...@apache.org
Subject [4/4] incubator-kudu git commit: Fix a minor code issue in tablet.cc
Date Fri, 26 Feb 2016 21:22:59 GMT
Fix a minor code issue in tablet.cc

When looked through the code, this line confused me:

  ops.reserve(ops.size());

After looking carefully I think it should be row_ops.

Change-Id: Ida5840b0dc0851c64453035fb7856dfde15d88c4
Reviewed-on: http://gerrit.cloudera.org:8080/2324
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <todd@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/d17c74f3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/d17c74f3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/d17c74f3

Branch: refs/heads/master
Commit: d17c74f321a1670dfb63a68d8123f7530a249cde
Parents: 25cac56
Author: Binglin Chang <decstery@gmail.com>
Authored: Fri Feb 26 15:30:29 2016 +0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Fri Feb 26 08:25:53 2016 +0000

----------------------------------------------------------------------
 src/kudu/tablet/tablet.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/d17c74f3/src/kudu/tablet/tablet.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet.cc b/src/kudu/tablet/tablet.cc
index 82699fe..40d61d9 100644
--- a/src/kudu/tablet/tablet.cc
+++ b/src/kudu/tablet/tablet.cc
@@ -282,7 +282,7 @@ Status Tablet::DecodeWriteOperations(const Schema* client_schema,
 
   // Create RowOp objects for each
   vector<RowOp*> row_ops;
-  ops.reserve(ops.size());
+  row_ops.reserve(ops.size());
   for (const DecodedRowOperation& op : ops) {
     row_ops.push_back(new RowOp(op));
   }


Mime
View raw message