kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [2/4] incubator-kudu git commit: KUDU-1305: do not allow building with gcc 4.6 and 4.7
Date Tue, 26 Jan 2016 17:14:00 GMT
KUDU-1305: do not allow building with gcc 4.6 and 4.7

They produce broken code in release mode ala KUDU-1030.

I tested this by running cmake with gcc 4.7, 4.8, and 5.2.

Change-Id: I0a6c3724f19cac207787b00e3b471f982f620c50
Reviewed-on: http://gerrit.cloudera.org:8080/1904
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <todd@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/3df123ac
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/3df123ac
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/3df123ac

Branch: refs/heads/master
Commit: 3df123ac7f71b44f64393c6637cebfffa38e623d
Parents: 21df2ba
Author: Adar Dembo <adar@cloudera.com>
Authored: Mon Jan 25 18:53:35 2016 -0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Tue Jan 26 16:34:14 2016 +0000

----------------------------------------------------------------------
 CMakeLists.txt | 9 +++++++++
 1 file changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/3df123ac/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 81b56be..6bdf7e0 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -181,6 +181,15 @@ if ("${COMPILER_FAMILY}" STREQUAL "clang")
   else()
     message("Running without a controlling terminal or in a dumb terminal")
   endif()
+elseif("${COMPILER_FAMILY}" STREQUAL "gcc")
+  # Blacklist gcc versions known to generate broken optimized code.
+  #
+  # See KUDU-1030 for more details.
+  if ("${COMPILER_VERSION}" MATCHES "^4.[67]")
+    message(FATAL_ERROR "Building with gcc version ${COMPILER_VERSION} is "
+      "forbidden as it is known to produce broken code in release mode. "
+      "Upgrade gcc, or build with clang from the thirdparty directory.")
+  endif()
 endif()
 
 # Sanity check linking option.


Mime
View raw message