kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [4/4] incubator-kudu git commit: Add missing override specifiers
Date Wed, 20 Jan 2016 00:35:39 GMT
Add missing override specifiers

This patch was created using the clang-modernize add-override transform
tool.

Change-Id: I2fe7cef4636462c6a1cb6423567613572a3f923c
Reviewed-on: http://gerrit.cloudera.org:8080/1802
Tested-by: Internal Jenkins
Reviewed-by: Dan Burkert <dan@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/4bff0cc3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/4bff0cc3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/4bff0cc3

Branch: refs/heads/master
Commit: 4bff0cc3cb65eeb4bd3a72d8ff6589fd542833f8
Parents: 6193411
Author: Dan Burkert <dan@cloudera.com>
Authored: Tue Nov 24 15:12:01 2015 -0800
Committer: Dan Burkert <dan@cloudera.com>
Committed: Wed Jan 20 00:35:06 2016 +0000

----------------------------------------------------------------------
 src/kudu/codegen/compilation_manager.cc    |  2 +-
 src/kudu/consensus/leader_election-test.cc |  2 +-
 src/kudu/tablet/memrowset.cc               | 17 ++++++++---------
 src/kudu/tserver/tablet_server-test.cc     |  2 +-
 src/kudu/util/debug/trace_logging.h        |  4 ++--
 src/kudu/util/metrics-test.cc              |  2 +-
 src/kudu/util/striped64.h                  |  4 +++-
 7 files changed, 17 insertions(+), 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/4bff0cc3/src/kudu/codegen/compilation_manager.cc
----------------------------------------------------------------------
diff --git a/src/kudu/codegen/compilation_manager.cc b/src/kudu/codegen/compilation_manager.cc
index 0cc3eb2..f832191 100644
--- a/src/kudu/codegen/compilation_manager.cc
+++ b/src/kudu/codegen/compilation_manager.cc
@@ -78,7 +78,7 @@ class CompilationTask : public Runnable {
       generator_(generator) {}
 
   // Can only be run once.
-  virtual void Run() {
+  virtual void Run() override {
     // We need to fail softly because the user could have just given
     // a malformed projection schema pair, but could be long gone by
     // now so there's nowhere to return the status to.

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/4bff0cc3/src/kudu/consensus/leader_election-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/leader_election-test.cc b/src/kudu/consensus/leader_election-test.cc
index 58b7014..6349d8f 100644
--- a/src/kudu/consensus/leader_election-test.cc
+++ b/src/kudu/consensus/leader_election-test.cc
@@ -66,7 +66,7 @@ class FromMapPeerProxyFactory : public PeerProxyFactory {
   }
 
   virtual Status NewProxy(const RaftPeerPB& peer_pb,
-                          gscoped_ptr<PeerProxy>* proxy) {
+                          gscoped_ptr<PeerProxy>* proxy) override {
     PeerProxy* proxy_ptr = FindPtrOrNull(*proxy_map_, peer_pb.permanent_uuid());
     if (!proxy_ptr) return Status::NotFound("No proxy for peer.");
     proxy->reset(proxy_ptr);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/4bff0cc3/src/kudu/tablet/memrowset.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/memrowset.cc b/src/kudu/tablet/memrowset.cc
index 1a9ab1d..4250fa5 100644
--- a/src/kudu/tablet/memrowset.cc
+++ b/src/kudu/tablet/memrowset.cc
@@ -328,25 +328,24 @@ class MRSRowProjectorImpl : public MRSRowProjector {
   explicit MRSRowProjectorImpl(gscoped_ptr<ActualProjector> actual)
     : actual_(actual.Pass()) {}
 
-  virtual Status Init() {
-    return actual_->Init();
-  }
+  virtual Status Init() override { return actual_->Init(); }
 
-  virtual Status ProjectRowForRead(const MRSRow& src_row,
-                                   RowBlockRow* dst_row,
-                                   Arena* arena) {
+  virtual Status ProjectRowForRead(const MRSRow& src_row, RowBlockRow* dst_row,
+                                   Arena* arena) override {
     return actual_->ProjectRowForRead(src_row, dst_row, arena);
   }
   virtual Status ProjectRowForRead(const ConstContiguousRow& src_row,
                                    RowBlockRow* dst_row,
-                                   Arena* arena) {
+                                   Arena* arena) override {
     return actual_->ProjectRowForRead(src_row, dst_row, arena);
   }
 
-  virtual const vector<ProjectionIdxMapping>& base_cols_mapping() const {
+  virtual const vector<ProjectionIdxMapping>& base_cols_mapping()
+      const override {
     return actual_->base_cols_mapping();
   }
-  virtual const vector<ProjectionIdxMapping>& adapter_cols_mapping() const {
+  virtual const vector<ProjectionIdxMapping>& adapter_cols_mapping()
+      const override {
     return actual_->adapter_cols_mapping();
   }
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/4bff0cc3/src/kudu/tserver/tablet_server-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/tablet_server-test.cc b/src/kudu/tserver/tablet_server-test.cc
index 0b397d7..313af17 100644
--- a/src/kudu/tserver/tablet_server-test.cc
+++ b/src/kudu/tserver/tablet_server-test.cc
@@ -2176,7 +2176,7 @@ class DelayFsyncLogHook : public log::Log::LogFaultHooks {
  public:
   DelayFsyncLogHook() : log_latch1_(1), test_latch1_(1) {}
 
-  virtual Status PostAppend() {
+  virtual Status PostAppend() override {
     test_latch1_.CountDown();
     log_latch1_.Wait();
     log_latch1_.Reset(1);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/4bff0cc3/src/kudu/util/debug/trace_logging.h
----------------------------------------------------------------------
diff --git a/src/kudu/util/debug/trace_logging.h b/src/kudu/util/debug/trace_logging.h
index 75f8bed..12654ae 100644
--- a/src/kudu/util/debug/trace_logging.h
+++ b/src/kudu/util/debug/trace_logging.h
@@ -85,8 +85,8 @@ class TraceVLog {
     explicit TraceLogSink(const char* category) : category_(category) {}
     virtual void send(google::LogSeverity severity, const char* full_filename,
                       const char* base_filename, int line,
-                      const struct ::tm* tm_time,
-                      const char* message, size_t message_len) {
+                      const struct ::tm* tm_time, const char* message,
+                      size_t message_len) override {
       // Rather than calling TRACE_EVENT_INSTANT here, we have to do it from
       // the destructor. This is because glog holds its internal mutex while
       // calling send(). So, if we try to use TRACE_EVENT here, and --trace_to_console

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/4bff0cc3/src/kudu/util/metrics-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/metrics-test.cc b/src/kudu/util/metrics-test.cc
index b038fd9..3d42832 100644
--- a/src/kudu/util/metrics-test.cc
+++ b/src/kudu/util/metrics-test.cc
@@ -42,7 +42,7 @@ METRIC_DEFINE_entity(test_entity);
 
 class MetricsTest : public KuduTest {
  public:
-  virtual void SetUp() {
+  virtual void SetUp() override {
     KuduTest::SetUp();
 
     entity_ = METRIC_ENTITY_test_entity.Instantiate(&registry_, "my-test");

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/4bff0cc3/src/kudu/util/striped64.h
----------------------------------------------------------------------
diff --git a/src/kudu/util/striped64.h b/src/kudu/util/striped64.h
index 15ed3c1..a7ffec7 100644
--- a/src/kudu/util/striped64.h
+++ b/src/kudu/util/striped64.h
@@ -166,7 +166,9 @@ class LongAdder : Striped64 {
   void Reset() { InternalReset(0); }
 
  private:
-  int64_t Fn(int64_t current_value, int64_t new_value) { return current_value + new_value;
}
+  int64_t Fn(int64_t current_value, int64_t new_value) override {
+    return current_value + new_value;
+  }
 
   DISALLOW_COPY_AND_ASSIGN(LongAdder);
 };


Mime
View raw message