knox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [knox] pzampino commented on a change in pull request #252: KNOX-2207 - TokenStateService revocation should remove persisted token state
Date Wed, 05 Feb 2020 15:57:58 GMT
pzampino commented on a change in pull request #252: KNOX-2207 - TokenStateService revocation
should remove persisted token state
URL: https://github.com/apache/knox/pull/252#discussion_r375340682
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
 ##########
 @@ -168,15 +167,15 @@ public boolean isExpired(final JWTToken token) {
 
   @Override
   public boolean isExpired(final String token) {
-    boolean isExpired;
+    boolean isUnknownToken;
 
 Review comment:
   Should still be isExpired ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message