From dev-return-20151-archive-asf-public=cust-asf.ponee.io@knox.apache.org Fri Mar 8 14:04:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 41093180626 for ; Fri, 8 Mar 2019 15:04:06 +0100 (CET) Received: (qmail 3082 invoked by uid 500); 8 Mar 2019 14:04:05 -0000 Mailing-List: contact dev-help@knox.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@knox.apache.org Delivered-To: mailing list dev@knox.apache.org Received: (qmail 3071 invoked by uid 99); 8 Mar 2019 14:04:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Mar 2019 14:04:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CCD09C1BB2 for ; Fri, 8 Mar 2019 14:04:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id RyicbmQAugIP for ; Fri, 8 Mar 2019 14:04:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0DE605F18F for ; Fri, 8 Mar 2019 14:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 78631E0D27 for ; Fri, 8 Mar 2019 14:04:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3160D257E1 for ; Fri, 8 Mar 2019 14:04:00 +0000 (UTC) Date: Fri, 8 Mar 2019 14:04:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@knox.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (KNOX-1774) Expose gateway.sh/ldap.sh environment variables for customization MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KNOX-1774?focusedWorklogId=3D2= 10157&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-210157 ] ASF GitHub Bot logged work on KNOX-1774: ---------------------------------------- Author: ASF GitHub Bot Created on: 08/Mar/19 14:03 Start Date: 08/Mar/19 14:03 Worklog Time Spent: 10m=20 Work Description: smolnar82 commented on pull request #65: KNOX-1774 = - Introducing environment variables in gateway/knoxcli/ldap/knoxshell scrip= ts for customization URL: https://github.com/apache/knox/pull/65#discussion_r263786190 =20 =20 ########## File path: gateway-server/src/main/java/org/apache/knox/gateway/config/imp= l/GatewayConfigImpl.java ########## @@ -259,18 +256,30 @@ private String getGatewayHomeDir() { =20 @Override public String getGatewayConfDir() { - String value =3D getVar( GATEWAY_CONF_HOME_VAR, getGatewayHomeDir() + = File.separator + "conf" ); - return FilenameUtils.normalize(value); + // 1st try: using the old style environment/system property name + @SuppressWarnings("deprecation") =20 Review comment: The old style env variable name (see GatwayConfig.GATEWAY_CONF_HOME) =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 210157) Time Spent: 2h 40m (was: 2.5h) > Expose gateway.sh/ldap.sh environment variables for customization > ----------------------------------------------------------------- > > Key: KNOX-1774 > URL: https://issues.apache.org/jira/browse/KNOX-1774 > Project: Apache Knox > Issue Type: Sub-task > Reporter: Kevin Risden > Assignee: Sandor Molnar > Priority: Major > Fix For: 1.3.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently there are a bunch of APP_* environment variables that can't be = customized without modifying the *.sh script.=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)