knox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (KNOX-1774) Expose gateway.sh/ldap.sh environment variables for customization
Date Fri, 08 Mar 2019 14:04:00 GMT

     [ https://issues.apache.org/jira/browse/KNOX-1774?focusedWorklogId=210157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-210157
]

ASF GitHub Bot logged work on KNOX-1774:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Mar/19 14:03
            Start Date: 08/Mar/19 14:03
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on pull request #65: KNOX-1774 - Introducing environment
variables in gateway/knoxcli/ldap/knoxshell scripts for customization
URL: https://github.com/apache/knox/pull/65#discussion_r263786190
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java
 ##########
 @@ -259,18 +256,30 @@ private String getGatewayHomeDir() {
 
   @Override
   public String getGatewayConfDir() {
-    String value = getVar( GATEWAY_CONF_HOME_VAR, getGatewayHomeDir() + File.separator +
"conf"  );
-    return FilenameUtils.normalize(value);
+    // 1st try: using the old style environment/system property name
+    @SuppressWarnings("deprecation")
 
 Review comment:
   The old style env variable name (see GatwayConfig.GATEWAY_CONF_HOME)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 210157)
    Time Spent: 2h 40m  (was: 2.5h)

> Expose gateway.sh/ldap.sh environment variables for customization
> -----------------------------------------------------------------
>
>                 Key: KNOX-1774
>                 URL: https://issues.apache.org/jira/browse/KNOX-1774
>             Project: Apache Knox
>          Issue Type: Sub-task
>            Reporter: Kevin Risden
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 1.3.0
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Currently there are a bunch of APP_* environment variables that can't be customized without
modifying the *.sh script. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message