Mailing-List: contact dev-help@knox.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@knox.apache.org
Date: Tue, 24 Oct 2017 19:19:00 +0000 (UTC)
From: "Larry McCay (JIRA)" <jira@apache.org>
To: dev@knox.incubator.apache.org
Message-ID: <JIRA.13058593.1490276063000.48992.1508872740405@Atlassian.JIRA>
In-Reply-To: <JIRA.13058593.1490276063000@Atlassian.JIRA>
References: <JIRA.13058593.1490276063000@Atlassian.JIRA> <JIRA.13058593.1490276063138@jira-lw-us.apache.org>
Subject: [jira] [Updated] (KNOX-912) introduce a rule "decode" attribute to
 overwrite encoding behavior
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 24 Oct 2017 19:19:10 -0000


     [ https://issues.apache.org/jira/browse/KNOX-912?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:all-tabpanel ]

Larry McCay updated KNOX-912:
-----------------------------
    Fix Version/s:     (was: 0.14.0)
                   0.15.0

> introduce a rule "decode" attribute to overwrite encoding behavior
> ------------------------------------------------------------------
>
>                 Key: KNOX-912
>                 URL: https://issues.apache.org/jira/browse/KNOX-912
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 0.13.0
>         Environment: all
>            Reporter: Jeffrey E  Rodriguez
>            Assignee: Jeffrey E  Rodriguez
>             Fix For: 0.15.0
>
>
> KNOX-791 - which tries to address the escaping issues have caused some is=
sues in some cases where we need to decode  "&amp;amp;" to "&" like in outp=
ut rewrites of query parameters
> An improvement  proposal to introduce a rule decode attribute to set deco=
ding behavior.=20
> Default is no decoding.=20
> This allows to turn this =E2=80=9Con=E2=80=9D for a specific rule.
> Before KNOX-791 "&amp;amp;" used to be decoded to "&" during html parsing=
.
> The issue is that in OUT rewrite rule we will not able to match the query=
 string.
> Example:
> given html
> <a href=3Dhttp://foo:99/test/&amp;q=3Dbar=E2=80=9D>test</a>
> rule:
> {code:xml}
> <rule dir=3D"OUT" name=3D"test"   pattern=3D"("{scheme}://{host}:{port}/t=
est/?{*}">
>      <rewrite template=3D"("http://newtest/test/?{*}?{scheme}?{host}?{por=
t}"/>
>  </rule>
> {code}
> This rule above will not work since the =E2=80=9C&amp; amp;=E2=80=9C will=
 not be matched.
> The proposed change is:
> {code:xml}
> <rule dir=3D"OUT" name=3D"test" decode=3D"true"  pattern=3D"("{scheme}://=
{host}:{port}/test/?{*}">
>      <rewrite template=3D"("http://newtest/test/?{*}?{scheme}?{host}?{por=
t}"/>
>  </rule>
> {code}
> This will overwrite the default behavior and decode the the &amp;
> The following test illustrates the issue of what we would like
> to solve.
> {code:title=3DtestAmpRewrite.java|borderStyle=3Dsolid}
> @Test
>   public void testAmpRewrite() throws Exception {
>     URI goodUri, badUri, outputUri;
>     Matcher<Void> matcher;
>     Matcher<Void>.Match match;
>     Template input, pattern, template;
>     badUri =3D new URI(
>         "http://foo:99/test/&amp;q=3Dbar"); // we should be able to match
>     goodUri =3D new URI(
>         "http://foo:99/test/?q=3Dbar");
>     input =3D Parser.parseLiteral(goodUri.toString());
>     pattern =3D Parser.parseTemplate("{scheme}://{host}:{port}/test/?{*}"=
);
>     template =3D Parser.parseTemplate("http://newtest/test/?{*}?{scheme}?=
{host}?{port}");
>     // Match query string
>     String expectedUri =3D "http://newtest/test/?scheme=3Dhttp&host=3Dfoo=
&port=3D99&q=3Dbar";
>     matcher =3D new Matcher<Void>();
>     matcher.add(pattern, null);
>     match =3D matcher.match(input);
>     assertNotNull( match );
>     outputUri =3D Expander.expand(template, match.getParams(), null);
>     assertEquals("Not matched", expectedUri, outputUri.toString());
>     // no match of query string ?
>     input =3D Parser.parseLiteral(badUri.toString());=20
>     match =3D matcher.match(input);
>     assertNull( match);
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)