Mailing-List: contact dev-help@knox.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@knox.apache.org
Date: Sat, 10 Sep 2016 00:36:20 +0000 (UTC)
From: "Sandeep More (JIRA)" <jira@apache.org>
To: dev@knox.incubator.apache.org
Message-ID: <JIRA.12996631.1470925811000.537573.1473467780459@Atlassian.JIRA>
In-Reply-To: <JIRA.12996631.1470925811000@Atlassian.JIRA>
References: <JIRA.12996631.1470925811000@Atlassian.JIRA> <JIRA.12996631.1470925811180@arcas>
Subject: [jira] [Commented] (KNOX-732) Knox does not recompress javascript
 resources
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 10 Sep 2016 00:36:24 -0000


    [ https://issues.apache.org/jira/browse/KNOX-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478790#comment-15478790 ] 

Sandeep More commented on KNOX-732:
-----------------------------------

Thanks for the quick review [~lmccay] !
Basically, I was trying to chain the gzipHandler, if you look the chain it is as follows contexts->logHandler->traceHandler->correlationHandler->gzipHandler. I did some debugging and I was able to step through gzipHandler and correlationHandler (in that particular order, which after your comments makes me thing is less desirable). 

Do you suggest I put correlationHandler at the end, wrapping gzipHandler (i.e. contexts->logHandler->traceHandler->gzipHandler->correlationHandler) ? 

Removing 
{code} gzipHandler.setHandler(correlationHandler); {code} skips the gzipHandler altogether so the fix would not work, there is a check in there which checks "_handler != null".

Let me know you thoughts.

Thanks !

> Knox does not recompress javascript resources
> ---------------------------------------------
>
>                 Key: KNOX-732
>                 URL: https://issues.apache.org/jira/browse/KNOX-732
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.9.1
>            Reporter: Sumit Gupta
>            Assignee: Sandeep More
>             Fix For: 0.10.0
>
>         Attachments: KNOX-732.001.patch, KNOX-732.002.patch
>
>
> When using the Ambari UI proxy service it is observed that the app.js file is about 7MB whereas it is much smaller (about 1MB) when the UI is not proxied by Knox. 
> A compression solution needs to be investigated. Possibly by adding a gzip compression handler or filter to jetty.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)