Mailing-List: contact user-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@karaf.apache.org
MIME-Version: 1.0
In-Reply-To: <1083807026.1445591.1500650829762@webmail.123-reg.co.uk>
References: <1781731028.1418776.1500630824787@webmail.123-reg.co.uk>
 <1cb26f7e-f178-4aef-9109-1cfb26fde2be@nanthrax.net> <1716460468.1421923.1500632841770@webmail.123-reg.co.uk>
 <38a642b1-ea49-225f-ebaf-1070e779f5a0@die-schneider.net> <CAA66TprAJh15104WfZFPRSnejPKGTr1VgbyQB5u__vGaqVSkRQ@mail.gmail.com>
 <1083807026.1445591.1500650829762@webmail.123-reg.co.uk>
From: Guillaume Nodet <gnodet@apache.org>
Date: Fri, 21 Jul 2017 17:52:28 +0200
Message-ID: <CAA66TppGf6DcfJuUvmuUEySkkuoY0KCwVQ+8r5LB8c3HN1=LFw@mail.gmail.com>
Subject: Re: Writing commands for karaf shell.
To: user <user@karaf.apache.org>, tom@quarendon.net
Content-Type: multipart/alternative; boundary="001a114f16946854eb0554d5dbb5"
archived-at: Fri, 21 Jul 2017 15:52:53 -0000

--001a114f16946854eb0554d5dbb5
Content-Type: text/plain; charset="UTF-8"

Right now, stick with the Karaf annotations if you want to deploy your
commands in Karaf.  It works and it's supported.
My previous comment was more a reply to Christian about what needs to be
done to support gogo commands in the future.

2017-07-21 17:27 GMT+02:00 <tom@quarendon.net>:

> > If you look at Karaf >= 4.1.x, a bunch of commands are not coming from
> > Karaf anymore, but from Gogo or JLine.  I moved them when working on the
> > gogo / jline3 integration.  The main point that was blocking imho is that
> > they did not have completion support.  With the new fully scripted
> > completion system from gogo-jline, gogo commands can have full
> completion,
> > so I don't see any blocking points anymore.  It's just about tracking
> > commands and registering them in the karaf shell.
>
> I'm sorry, but I don't really understand what you're saying. You're
> talking about impediments to making changes to Karaf? Or how I go about
> writing commands?
> Sorry, just not following.
>
> Fundamentally, should commands that I write using apache felix gogo
> command features such as the Parameter and Description annotations, and the
> CommandService interface work? Or if I want to do something other than a
> simple "hello world", do I need to work out how to use the karaf shell from
> within bndtools so that I can write commands using the Karaf command
> framework?
>
> Thanks.
>


-- 
------------------------
Guillaume Nodet

--001a114f16946854eb0554d5dbb5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Right now, stick with the Karaf annotations if you want to=
 deploy your commands in Karaf.=C2=A0 It works and it&#39;s supported. =C2=
=A0<div>My previous comment was more a reply to Christian about what needs =
to be done to support gogo commands in the future.<br><div class=3D"gmail_e=
xtra"><br><div class=3D"gmail_quote">2017-07-21 17:27 GMT+02:00  <span dir=
=3D"ltr">&lt;<a href=3D"mailto:tom@quarendon.net" target=3D"_blank">tom@qua=
rendon.net</a>&gt;</span>:<br><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=3D=
"">&gt; If you look at Karaf &gt;=3D 4.1.x, a bunch of commands are not com=
ing from<br>
&gt; Karaf anymore, but from Gogo or JLine.=C2=A0 I moved them when working=
 on the<br>
&gt; gogo / jline3 integration.=C2=A0 The main point that was blocking imho=
 is that<br>
&gt; they did not have completion support.=C2=A0 With the new fully scripte=
d<br>
&gt; completion system from gogo-jline, gogo commands can have full complet=
ion,<br>
&gt; so I don&#39;t see any blocking points anymore.=C2=A0 It&#39;s just ab=
out tracking<br>
&gt; commands and registering them in the karaf shell.<br>
<br>
</span>I&#39;m sorry, but I don&#39;t really understand what you&#39;re say=
ing. You&#39;re talking about impediments to making changes to Karaf? Or ho=
w I go about writing commands?<br>
Sorry, just not following.<br>
<br>
Fundamentally, should commands that I write using apache felix gogo command=
 features such as the Parameter and Description annotations, and the Comman=
dService interface work? Or if I want to do something other than a simple &=
quot;hello world&quot;, do I need to work out how to use the karaf shell fr=
om within bndtools so that I can write commands using the Karaf command fra=
mework?<br>
<br>
Thanks.<br>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=
=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><d=
iv><div dir=3D"ltr"><font color=3D"#999999">------------------------<br>Gui=
llaume Nodet<br></font><div><br></div></div></div></div></div>
</div></div></div>

--001a114f16946854eb0554d5dbb5--