karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-5712) Upgrade website style to bootstrap 4
Date Tue, 12 Jun 2018 08:25:00 GMT

    [ https://issues.apache.org/jira/browse/KARAF-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509329#comment-16509329
] 

ASF GitHub Bot commented on KARAF-5712:
---------------------------------------

jbonofre commented on a change in pull request #9: [KARAF-5712] Change responsive css to Bootstrap
URL: https://github.com/apache/karaf-site/pull/9#discussion_r194651620
 
 

 ##########
 File path: src/main/webapp/community.html
 ##########
 @@ -120,82 +166,97 @@ <h3 id="pull-request">Provide changes in a pull request</h3>
                     <li>You can squash your commits into one and force push your branch
(not mandatory) using <code>git rebase -i apache/master</code></li>
                     <li>Test that your change works by adapting or adding tests.</li>
                     <li><a href="http://programmer.97things.oreilly.com/wiki/index.php/The_Boy_Scout_Rule">Follow
the boy scout rule to "Always leave the campground cleaner than you found it."</a></li>
-                    <li>Make sure you do a build before doing a PR. The build has to
be successfull:<br/>
-                		<code>
+                    <li>Make sure you do a build before doing a PR. The build has to
be successfull :<br/>
+                        <code>
                             mvn clean verify -Prelease -fae -T 1C
-                		</code>
-            	    </li>
+                        </code>
+                    </li>
                     <li>If your PR has conflicts with the master then rebase the branch.
PRs with conflicts are unlikely to be applied</li>
                     <li>Do not change too much in a PR. The smaller the PR the easier
it is to apply and the faster it will be done</li>
                     <li>Sometimes PRs get lost. Do not hesitate to ask on the dev list
if your PR seems to be ignored</li>
-                </ul>
-                
-                <div class="content--panel--separator"></div>
+              </ul>            
+            </div>
+        </div>
 
-                <h3 id="review-pull-request">Review pull requests</h3>
-                
-                Anyone can review pull requests but the merge can be done only by a committer.<br/>
+        <div class="row mb-5 mt-5">
+            <div class="col">
+              <h4 class="pb-3 mb-4">Review pull requests</h4>
+              <p>Anyone can review pull requests but the merge can be done only by
a committer.<br/>
                 If you want to review a PR then comment with <code>R:@yourgithubid</code>.
This marks that you will do the review and also apply if you are a committer.<br/>
 
 Review comment:
   We can mention the "Reviewer" entry on the right menu, allowing a committer to be reviewer
(no need to use `R:` in that case).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Upgrade website style to bootstrap 4
> ------------------------------------
>
>                 Key: KARAF-5712
>                 URL: https://issues.apache.org/jira/browse/KARAF-5712
>             Project: Karaf
>          Issue Type: Improvement
>          Components: website
>            Reporter: Francois Papon
>            Assignee: Francois Papon
>            Priority: Minor
>
> It would be great to upgrade the website style with Bootstrap 4 for responsive design
compatibility and to be more easy to upgrade content and style.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message