From issues-return-39367-archive-asf-public=cust-asf.ponee.io@karaf.apache.org Thu Apr 12 14:14:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 66306180634 for ; Thu, 12 Apr 2018 14:14:03 +0200 (CEST) Received: (qmail 16461 invoked by uid 500); 12 Apr 2018 12:14:02 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 16448 invoked by uid 99); 12 Apr 2018 12:14:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 12:14:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E49B2C0157 for ; Thu, 12 Apr 2018 12:14:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.31 X-Spam-Level: X-Spam-Status: No, score=-110.31 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100, WEIRD_PORT=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id OZHv4HYEdrPm for ; Thu, 12 Apr 2018 12:14:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CA54C5F4AD for ; Thu, 12 Apr 2018 12:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 63A8EE0C25 for ; Thu, 12 Apr 2018 12:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1DA4C241C4 for ; Thu, 12 Apr 2018 12:14:00 +0000 (UTC) Date: Thu, 12 Apr 2018 12:14:00 +0000 (UTC) From: "Freeman Fang (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-5694) strip url to ensure it's a valid one which could download MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435453#comment-16435453 ] Freeman Fang commented on KARAF-5694: ------------------------------------- [~gzres], good catch, thanks! But specify a single startBundle with start-level is convenient. I think we can check if it's suffix is ";start-level", if so, remove it. This won't mess the OSGi instructions in wrap uri IMO. > strip url to ensure it's a valid one which could download > --------------------------------------------------------- > > Key: KARAF-5694 > URL: https://issues.apache.org/jira/browse/KARAF-5694 > Project: Karaf > Issue Type: Bug > Components: karaf-feature > Affects Versions: 4.2.0 > Reporter: Freeman Fang > Assignee: Freeman Fang > Priority: Major > Fix For: 4.1.6, 4.2.1 > > > For example, if we configuration > {code} > > mvn:${project.groupId}/${project.artifactId}/${project.version};start-level=80 > > {code} > in karaf-maven-plugin which have start-level for a bundle, then we have error like > {code} > Caused by: java.io.FileNotFoundException: ....../1.0-SNAPSHOT/camel-websocket-1.0-SNAPSHOT.jar;start-level=80 (No such file or directory) > at java.io.FileInputStream.open0(Native Method) ~[?:?] > at java.io.FileInputStream.open(FileInputStream.java:195) ~[?:?] > at java.io.FileInputStream.(FileInputStream.java:138) ~[?:?] > at java.io.FileInputStream.(FileInputStream.java:93) ~[?:?] > at sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90) ~[?:?] > at sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188) ~[?:?] > at java.net.URL.openStream(URL.java:1045) ~[?:?] > at org.apache.karaf.features.internal.download.impl.SimpleDownloadTask.download(SimpleDownloadTask.java:76) ~[?:?] > at org.apache.karaf.features.internal.download.impl.AbstractRetryableDownloadTask.run(AbstractRetryableDownloadTask.java:60) ~[?:?] > {code} > we need strip unnecessary part in the url before open the stream -- This message was sent by Atlassian JIRA (v7.6.3#76005)