karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-5679) Upgrade to Hibernate Validator 6.0.9.Final
Date Thu, 29 Mar 2018 05:42:00 GMT

    [ https://issues.apache.org/jira/browse/KARAF-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418468#comment-16418468
] 

ASF GitHub Bot commented on KARAF-5679:
---------------------------------------

jbonofre closed pull request #482: [KARAF-5679] Upgrade to Hibernate Validator 6.0.9.Final
URL: https://github.com/apache/karaf/pull/482
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/assemblies/features/enterprise/src/main/feature/feature.xml b/assemblies/features/enterprise/src/main/feature/feature.xml
index 270d2b1177..b12a5e1ae7 100644
--- a/assemblies/features/enterprise/src/main/feature/feature.xml
+++ b/assemblies/features/enterprise/src/main/feature/feature.xml
@@ -20,7 +20,7 @@
 
     <!-- NB: this file is not the one really used. This file is used by the karaf-maven-plugin
to define the start-level of bundles in the generated feature.xml -->
 
-    <repository>mvn:org.hibernate/hibernate-validator-osgi-karaf-features/${hibernate.validator.version}/xml/features</repository>
+    <repository>mvn:org.hibernate.validator/hibernate-validator-osgi-karaf-features/${hibernate.validator.version}/xml/features</repository>
     <repository>mvn:org.hibernate/hibernate-osgi/${hibernate.version}/xml/karaf</repository>
     <repository>mvn:org.ops4j.pax.cdi/pax-cdi-features/${pax.cdi.version}/xml/features</repository>
     <repository>mvn:org.ops4j.pax.jdbc/pax-jdbc-features/${pax.jdbc.version}/xml/features</repository>
diff --git a/itests/src/test/java/org/apache/karaf/itests/features/EnterpriseFeaturesTest.java
b/itests/src/test/java/org/apache/karaf/itests/features/EnterpriseFeaturesTest.java
index 0132109a80..12bb094a40 100644
--- a/itests/src/test/java/org/apache/karaf/itests/features/EnterpriseFeaturesTest.java
+++ b/itests/src/test/java/org/apache/karaf/itests/features/EnterpriseFeaturesTest.java
@@ -114,8 +114,12 @@ public void installHibernateEnvers436FinalFeature() throws Exception
{
     }
 
     @Test
-    public void installHibernateValidatorFeature() throws Exception {
+    public void installHibernateValidatorFeatures() throws Exception {
         installAssertAndUninstallFeatures("hibernate-validator");
+        installAssertAndUninstallFeatures("hibernate-validator-jsoup");
+        installAssertAndUninstallFeatures("hibernate-validator-joda-time");
+        installAssertAndUninstallFeatures("hibernate-validator-javax-money");
+        installAssertAndUninstallFeatures("hibernate-validator-groovy");
     }
 
     @Test
diff --git a/pom.xml b/pom.xml
index 98bbe406a2..f4fa8783f1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -257,7 +257,7 @@
         <hibernate42.version>4.2.15.Final</hibernate42.version>
         <hibernate43.version>4.3.6.Final</hibernate43.version>
         <hibernate.version>5.2.9.Final</hibernate.version>
-        <hibernate.validator.version>5.4.2.Final</hibernate.validator.version>
+        <hibernate.validator.version>6.0.9.Final</hibernate.validator.version>
         <jansi.version>1.17</jansi.version>
         <javassist.version>3.9.0.GA</javassist.version>
         <jetty.version>9.4.6.v20170531</jetty.version>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Upgrade to Hibernate Validator 6.0.9.Final
> ------------------------------------------
>
>                 Key: KARAF-5679
>                 URL: https://issues.apache.org/jira/browse/KARAF-5679
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Guillaume Smet
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Karaf is currently proposing Hibernate Validator 5.4.2.Final whereas it could use the
latest 6.0.9.Final.
> HV 6.0 is highly compatible with HV 5.4.2.Final so it should be a safe upgrade.
> In HV 6.0.9.Final, we split the hibernate-validator feature in smaller features to avoid
having too many dependencies. See http://search.maven.org/remotecontent?filepath=org/hibernate/validator/hibernate-validator-osgi-karaf-features/6.0.9.Final/hibernate-validator-osgi-karaf-features-6.0.9.Final-features.xml
.
> Pull request to come.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message