From issues-return-38703-archive-asf-public=cust-asf.ponee.io@karaf.apache.org Sat Feb 10 09:08:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id EB13518061A for ; Sat, 10 Feb 2018 09:08:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DADA0160C4D; Sat, 10 Feb 2018 08:08:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06158160C30 for ; Sat, 10 Feb 2018 09:08:05 +0100 (CET) Received: (qmail 13564 invoked by uid 500); 10 Feb 2018 08:08:05 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 13553 invoked by uid 99); 10 Feb 2018 08:08:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Feb 2018 08:08:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A182EC0163 for ; Sat, 10 Feb 2018 08:08:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id MMR4SD7mNQhh for ; Sat, 10 Feb 2018 08:08:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 39EC85F576 for ; Sat, 10 Feb 2018 08:08:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5DB14E002F for ; Sat, 10 Feb 2018 08:08:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1EBD521E85 for ; Sat, 10 Feb 2018 08:08:00 +0000 (UTC) Date: Sat, 10 Feb 2018 08:08:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-5559) log:tail kills ssh & karaf when root logger is in DEBUG MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-5559?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1635= 9319#comment-16359319 ]=20 ASF GitHub Bot commented on KARAF-5559: --------------------------------------- jbonofre closed pull request #448: [KARAF-5559]=C2=A0Change the sshd log le= vel in log:tail & log:display commands to avoid infinite loop using ssh URL: https://github.com/apache/karaf/pull/448 =20 =20 =20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/assemblies/features/base/src/main/resources/resources/etc/org.= ops4j.pax.logging.cfg b/assemblies/features/base/src/main/resources/resourc= es/etc/org.ops4j.pax.logging.cfg index 6cd8240fa6..ec0b7737fc 100644 --- a/assemblies/features/base/src/main/resources/resources/etc/org.ops4j.p= ax.logging.cfg +++ b/assemblies/features/base/src/main/resources/resources/etc/org.ops4j.p= ax.logging.cfg @@ -43,6 +43,10 @@ log4j2.rootLogger.appenderRef.Console.filter.threshold.l= evel =3D ${karaf.log.conso =20 # Loggers configuration =20 +# SSHD logger +log4j2.logger.sshd.name =3D org.apache.sshd +log4j2.logger.sshd.level =3D INFO + # Spifly logger log4j2.logger.spifly.name =3D org.apache.aries.spifly log4j2.logger.spifly.level =3D WARN diff --git a/log/src/main/java/org/apache/karaf/log/command/DisplayLog.java= b/log/src/main/java/org/apache/karaf/log/command/DisplayLog.java index 076b8ecbab..16a3296c90 100644 --- a/log/src/main/java/org/apache/karaf/log/command/DisplayLog.java +++ b/log/src/main/java/org/apache/karaf/log/command/DisplayLog.java @@ -42,6 +42,8 @@ public final static int INFO_INT =3D 6; public final static int DEBUG_INT =3D 7; =20 + private final static String SSHD_LOGGER =3D "org.apache.sshd"; + @Option(name =3D "-n", aliases =3D {}, description=3D"Number of entrie= s to display", required =3D false, multiValued =3D false) int entries; =20 @@ -68,8 +70,11 @@ public Object execute() throws Exception { final PrintStream out =3D System.out; int minLevel =3D getMinLevel(level); + String sshdLoggerLevel =3D logService.getLevel(SSHD_LOGGER).get(SS= HD_LOGGER); + logService.setLevel(SSHD_LOGGER, "ERROR"); display(out, minLevel); out.println(); + logService.setLevel(SSHD_LOGGER, sshdLoggerLevel); return null; } =20 diff --git a/log/src/main/java/org/apache/karaf/log/command/LogTail.java b/= log/src/main/java/org/apache/karaf/log/command/LogTail.java index dc67e2627e..7d4ab50b69 100644 --- a/log/src/main/java/org/apache/karaf/log/command/LogTail.java +++ b/log/src/main/java/org/apache/karaf/log/command/LogTail.java @@ -74,7 +74,12 @@ private synchronized void stopTail() { * Track LogService dynamically so we can react when the log core bund= le stops even while we block for the tail */ private final class LogServiceTracker extends ServiceTracker { + + private final static String SSHD_LOGGER =3D "org.apache.sshd"; + private final PaxAppender appender; + + private String sshdLoggerLevel; =20 private LogServiceTracker(BundleContext context, Class= clazz, ServiceTrackerCustomizer customizer, @@ -86,12 +91,17 @@ private LogServiceTracker(BundleContext context, Class<= LogService> clazz, @Override public LogService addingService(ServiceReference refer= ence) { LogService service =3D super.addingService(reference); + sshdLoggerLevel =3D service.getLevel(SSHD_LOGGER).get(SSHD_LOG= GER); + service.setLevel(SSHD_LOGGER, "ERROR"); service.addAppender(appender); return service; } =20 @Override public void removedService(ServiceReference reference,= LogService service) { + if (sshdLoggerLevel !=3D null) { + service.setLevel(SSHD_LOGGER, sshdLoggerLevel); + } service.removeAppender(appender); stopTail(); } =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > log:tail kills ssh & karaf when root logger is in DEBUG > ------------------------------------------------------- > > Key: KARAF-5559 > URL: https://issues.apache.org/jira/browse/KARAF-5559 > Project: Karaf > Issue Type: Bug > Components: karaf-logging, karaf-shell > Affects Versions: 4.1.4, 4.2.0.M2 > Reporter: Jean-Baptiste Onofr=C3=A9 > Assignee: Jean-Baptiste Onofr=C3=A9 > Priority: Major > Fix For: 4.2.0, 4.1.5 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)