From issues-return-38487-archive-asf-public=cust-asf.ponee.io@karaf.apache.org Wed Jan 31 15:00:11 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 533F9180662 for ; Wed, 31 Jan 2018 15:00:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 42036160C57; Wed, 31 Jan 2018 14:00:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 89663160C35 for ; Wed, 31 Jan 2018 15:00:10 +0100 (CET) Received: (qmail 3412 invoked by uid 500); 31 Jan 2018 14:00:09 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 3399 invoked by uid 99); 31 Jan 2018 14:00:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Jan 2018 14:00:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 241341A55AC for ; Wed, 31 Jan 2018 14:00:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5qxFg3n_bdmo for ; Wed, 31 Jan 2018 14:00:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 734BD60DB5 for ; Wed, 31 Jan 2018 14:00:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AF65DE01DC for ; Wed, 31 Jan 2018 14:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D850624106 for ; Wed, 31 Jan 2018 14:00:00 +0000 (UTC) Date: Wed, 31 Jan 2018 14:00:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-4288) karaf-maven-plugin doesn't pass custom settings.xml option onto pax-url-aether MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-4288?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1634= 6867#comment-16346867 ]=20 ASF subversion and git services commented on KARAF-4288: -------------------------------------------------------- Commit fac27e4ad33d1bc7a790885c6255a1c4c50d1614 in karaf's branch refs/head= s/karaf-4.1.x from [~splatch] [ https://gitbox.apache.org/repos/asf?p=3Dkaraf.git;h=3Dfac27e4 ] KARAF-5585 Do not provide maven settings to pax url if they are gone. This commit rollbacks/moves changes made in KARAF-4288 to verify mojo. > karaf-maven-plugin doesn't pass custom settings.xml option onto pax-url-a= ether > -------------------------------------------------------------------------= ----- > > Key: KARAF-4288 > URL: https://issues.apache.org/jira/browse/KARAF-4288 > Project: Karaf > Issue Type: Bug > Components: karaf-tooling > Affects Versions: 4.0.4 > Reporter: Stuart McCulloch > Assignee: Jean-Baptiste Onofr=C3=A9 > Priority: Major > Fix For: 4.1.0, 4.0.5 > > Attachments: KARAF-4288.patch > > > When adding features to a custom distribution karaf-maven-plugin uses pax= -url-aether to fetch artifacts which don't yet exist in the local maven rep= ository. > pax-url-aether has logic to discover the local repository and settings.xm= l file, but this relies on defaults plus a few heuristics. If a Maven build= uses a custom settings.xml file which contains auth details, ie. when runn= ing on CI, then this is not picked up by pax-url-aether and it cannot fetch= down additional content. > The current user settings file is accessible from the MavenSession which = is already available in Karaf's MojoSupport: > MavenSession->getRequest->getUserSettingsFile > All that needs to be done is to pass this path to pax-url-aether by setti= ng the "org.ops4j.pax.url.mvn.settings" system property. Note the custom us= er settings file may be null or may not exist, in which case pax-url-aether= should use the global settings. Since it already has code to discover the = global settings using known locations we don't need to pass this on, so we = just avoid setting "org.ops4j.pax.url.mvn.settings" in this case. > (I'll attach a patch that implements this suggested solution) -- This message was sent by Atlassian JIRA (v7.6.3#76005)