Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F0FC7200D78 for ; Wed, 6 Dec 2017 14:04:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EFD27160BFD; Wed, 6 Dec 2017 13:04:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2C70D160C08 for ; Wed, 6 Dec 2017 14:04:09 +0100 (CET) Received: (qmail 73062 invoked by uid 500); 6 Dec 2017 13:04:06 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 72892 invoked by uid 99); 6 Dec 2017 13:04:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Dec 2017 13:04:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 841DBC0570 for ; Wed, 6 Dec 2017 13:04:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id NRIVMXGGxnLj for ; Wed, 6 Dec 2017 13:04:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 66FDC5F30A for ; Wed, 6 Dec 2017 13:04:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1054BE25B2 for ; Wed, 6 Dec 2017 13:04:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3924D255D3 for ; Wed, 6 Dec 2017 13:04:01 +0000 (UTC) Date: Wed, 6 Dec 2017 13:04:01 +0000 (UTC) From: "Grzegorz Grzybek (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-4684) karaf-maven-plugin assembly goal fails to find nested features with explicit version containing qualifier MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 06 Dec 2017 13:04:10 -0000 [ https://issues.apache.org/jira/browse/KARAF-4684?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1628= 0149#comment-16280149 ]=20 Grzegorz Grzybek commented on KARAF-4684: ----------------------------------------- I checked your scenario with upcoming Karaf 4.2. First I did: {noformat} 13:56 $ git diff diff --git a/assembly/pom.xml b/assembly/pom.xml index e3b48b3..4fa4add 100644 --- a/assembly/pom.xml +++ b/assembly/pom.xml @@ -12,7 +12,7 @@ Simple custom assembly which includes a simple project fe= ature set on top of minimal distribution =20 - 4.0.6 + 4.2.0-SNAPSHOT 1.0-SNAPSHOT =20 @@ -94,6 +94,12 @@ features xml + + org.deklanowski.karaf + impl + ${sample.version} + runtime + org.deklanowski.karaf features {noformat} To change the order of artifacts - so assembly artifact is built *after* ap= i and impl. Everything was resolved having your: {code:xml} api mvn:org.deklanowski.karaf/impl/${project.version} {code} Proper version was included in {{sample-karaf-assembly/assembly/target/asse= mbly/system/org/deklanowski/karaf/features/1.0-SNAPSHOT/features-1.0-SNAPSH= OT-features.xml}}: {code:xml} mvn:org.deklanowski.karaf/api/1.0-SNAPSHOT api mvn:org.deklanowski.karaf/impl/1.0-SNAPSHOT {code} And I could even run your distro: {noformat} karaf@root()> la -l START LEVEL 100 , List Threshold: 0 ID =E2=94=82 State =E2=94=82 Lvl =E2=94=82 Version =E2=94= =82 Location =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=BC=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=BC=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=BC=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=BC=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80 0 =E2=94=82 Active =E2=94=82 0 =E2=94=82 5.6.10 =E2=94= =82 System Bundle 1 =E2=94=82 Resolved =E2=94=82 1 =E2=94=82 2.6.0 =E2=94= =82 mvn:org.apache.felix/org.apache.felix.framework.security/2.6.0 2 =E2=94=82 Resolved =E2=94=82 1 =E2=94=82 4.2.0.SNAPSHOT =E2=94= =82 mvn:org.apache.karaf.features/org.apache.karaf.features.extension/4.2.0= -SNAPSHOT ... 137 =E2=94=82 Active =E2=94=82 80 =E2=94=82 1.0.0.SNAPSHOT =E2=94= =82 mvn:org.deklanowski.karaf/api/1.0-SNAPSHOT 138 =E2=94=82 Active =E2=94=82 80 =E2=94=82 1.0.0.SNAPSHOT =E2=94= =82 mvn:org.deklanowski.karaf/impl/1.0-SNAPSHOT 139 =E2=94=82 Active =E2=94=82 30 =E2=94=82 8.1.14.v20131031 =E2=94= =82 mvn:org.eclipse.jetty.aggregate/jetty-all-server/8.1.14.v20131031 {noformat} > karaf-maven-plugin assembly goal fails to find nested features with expli= cit version containing qualifier > -------------------------------------------------------------------------= -------------------------------- > > Key: KARAF-4684 > URL: https://issues.apache.org/jira/browse/KARAF-4684 > Project: Karaf > Issue Type: Bug > Components: karaf-profile > Affects Versions: 4.0.5, 4.0.6 > Reporter: Declan Cox > Assignee: Grzegorz Grzybek > Priority: Minor > Fix For: 4.2.0 > > > In karaf 4.0.5 and 4.0.6 (at least) there is an issue with nested feature= s which explicitly declare a version when that version has a qualifier e.g.= , such as development snapshot version like 1.0-SNAPSHOT or a release quali= fier like for example 1.0.0-RELEASE. > =20 > For example, take our features descriptor for a simple project: > {noformat} > > mvn:org.deklanowski.karaf/api/${project.version} > > > api=20 > > mvn:org.deklanowski.karaf/impl/${project.version} > > {noformat} > If we explicitly include the version of the nested api feature inside the= impl feature then=20 > you will get the following output when building the assembly: > {noformat} > [INFO] Reactor Summary: > [INFO]=20 > [INFO] sample feature ..................................... SUCCESS [ 0.= 116 s] > [INFO] sample karaf feature repository .................... SUCCESS [ 0.= 763 s] > [INFO] sample karaf assembly configuration ................ FAILURE [ 2.= 727 s] > [INFO] sample feature api ................................. SKIPPED > [INFO] sample feature impl ................................ SKIPPED > [INFO] sample assembly reactor ............................ SKIPPED > [INFO] ------------------------------------------------------------------= ------ > [INFO] BUILD FAILURE > [INFO] ------------------------------------------------------------------= ------ > [INFO] Total time: 5.178 s > [INFO] Finished at: 2016-08-30T10:52:02+01:00 > [INFO] Final Memory: 23M/399M > [INFO] ------------------------------------------------------------------= ------ > [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugi= n:4.0.6:assembly (default-assembly) on project assembly: Unable to build as= sembly: Could not find matching feature for api/1.0-SNAPSHOT -> {noformat} > Excluding the version number solves the issue. As stated this is not limi= ted to snapshot qualifiers, any qualifier of the form {noformat}'-'{noformat} seems to do it.=20 > Debugging the assembly yields the problem emanating from the recursive ad= dFeatures method in the karaf assembly building subsystem [Builder.java|htt= ps://github.com/apache/karaf/blob/karaf-4.0.6/profile/src/main/java/org/apa= che/karaf/profile/assembly/Builder.java].=20 > Please see my sample project and debug screenshots in [sample-karaf-assem= bly|https://github.com/deklanowski/sample-karaf-assembly] -- This message was sent by Atlassian JIRA (v6.4.14#64029)