karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grzegorz Grzybek (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (KARAF-5273) karaf-maven-plugin assembly should take feature wildcards
Date Wed, 06 Dec 2017 12:31:00 GMT

    [ https://issues.apache.org/jira/browse/KARAF-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280111#comment-16280111
] 

Grzegorz Grzybek edited comment on KARAF-5273 at 12/6/17 12:30 PM:
-------------------------------------------------------------------

Building on "overrides 2.0" (KARAF-5376), I allowed to specify feature patterns in profiles
and in karaf-maven-plugin:assembly goal configuration. Having (quite artificial):
{code:xml}
<startupFeatures>
    <f>my-*-feature</f>
</startupFeatures>
<bootFeatures>
    <f>my-*</f>
</bootFeatures>
<installedFeatures>
    <f>my*feature</f>
</installedFeatures>
{code}

We can see in logs:
{noformat}
[INFO] --- karaf-maven-plugin:4.2.0-SNAPSHOT:assembly (default-assembly) @ test-karaf-plugins
---
...
[INFO] Creating work directory: /data/sources/_testing/grgr-test-karaf-plugins/target/assembly
...
[INFO] Startup stage
[INFO]    Loading startup repositories
[INFO]    Resolving startup features and bundles
[INFO]       Features: undertow, my-*-feature
...
[INFO] Boot stage
...
[INFO]    Feature my-startup-feature/0.1.0.BUILD-SNAPSHOT is defined as a boot feature
[INFO]       adding maven artifact: mvn:org.apache.karaf.features/org.apache.karaf.features.extension/4.2.0-SNAPSHOT
[INFO]       adding maven artifact: mvn:org.ops4j.pax.logging/pax-logging-api/1.10.1
[INFO]       adding maven artifact: mvn:org.ops4j.pax.url/pax-url-aether/2.5.3
...
[INFO] Install stage
...
[INFO]    Feature my-startup-feature/0.1.0.BUILD-SNAPSHOT is defined as an installed feature
[INFO]       adding maven artifact: mvn:org.apache.karaf.features/org.apache.karaf.features.extension/4.2.0-SNAPSHOT
[INFO]       adding maven artifact: mvn:org.ops4j.pax.logging/pax-logging-api/1.10.1
[INFO]       adding maven artifact: mvn:org.ops4j.pax.url/pax-url-aether/2.5.3
{noformat}

and generated {{etc/profile.cfg}} has:
{noformat}
# Features
feature.my-*-feature = my-*-feature
feature.my-* = my-*
feature.my*feature = my*feature
{noformat}

startup feature is correctly resolved into collection of {{etc/startup.properties}} bundles.


was (Author: gzres):
Building on "overrides 2.0" (KARAF-5376), I allowed to specify feature patterns in profiles
and in karaf-maven-plugin:assembly goal configuration. Having (quite artificial):
{code:xml}
<startupFeatures>
    <f>my-*-feature</f>
</startupFeatures>
<bootFeatures>
    <f>my-*</f>
</bootFeatures>
<installedFeatures>
    <f>my*feature</f>
</installedFeatures>
{code}

We can see in logs:
{noformat}
[INFO] --- karaf-maven-plugin:4.2.0-SNAPSHOT:assembly (default-assembly) @ test-karaf-plugins
---
...
[INFO] Creating work directory: /data/sources/_testing/grgr-test-karaf-plugins/target/assembly
...
[INFO] Startup stage
[INFO]    Loading startup repositories
[INFO]    Resolving startup features and bundles
[INFO]       Features: undertow, my-*-feature
...
[INFO] Boot stage
...
[INFO]    Feature my-startup-feature/0.1.0.BUILD-SNAPSHOT is defined as a boot feature
[INFO]       adding maven artifact: mvn:org.apache.karaf.features/org.apache.karaf.features.extension/4.2.0-SNAPSHOT
[INFO]       adding maven artifact: mvn:org.ops4j.pax.logging/pax-logging-api/1.10.1
[INFO]       adding maven artifact: mvn:org.ops4j.pax.url/pax-url-aether/2.5.3
...
[INFO] Install stage
...
[INFO]    Feature my-startup-feature/0.1.0.BUILD-SNAPSHOT is defined as an installed feature
[INFO]       adding maven artifact: mvn:org.apache.karaf.features/org.apache.karaf.features.extension/4.2.0-SNAPSHOT
[INFO]       adding maven artifact: mvn:org.ops4j.pax.logging/pax-logging-api/1.10.1
[INFO]       adding maven artifact: mvn:org.ops4j.pax.url/pax-url-aether/2.5.3
{noformat}

and generated {{etc/profile.cfg}} has:
{noformat}
# Features
feature.my-*-feature = my-*-feature
feature.my-* = my-*
feature.my*feature = my*feature
{noformat}


> karaf-maven-plugin assembly should take feature wildcards
> ---------------------------------------------------------
>
>                 Key: KARAF-5273
>                 URL: https://issues.apache.org/jira/browse/KARAF-5273
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-tooling
>            Reporter: Fabian Lange
>            Assignee: Grzegorz Grzybek
>             Fix For: 4.1.4, 4.2.0
>
>
> As per discussion in:
> http://karaf.922171.n3.nabble.com/Building-custom-dist-including-all-features-of-a-repository-td4051100.html
> it would be great if the assembly part of the karaf-maven-plugin would respect wildcards
for startup/boot/installed feature names. currently it only performs an equals check, requiring
dist builders to explicitly list all the features they want.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message