karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-3827) Cave rest service doesn't retrieve the repositories
Date Tue, 14 Nov 2017 20:33:00 GMT

    [ https://issues.apache.org/jira/browse/KARAF-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252134#comment-16252134
] 

ASF GitHub Bot commented on KARAF-3827:
---------------------------------------

fpapon commented on a change in pull request #6: [KARAF-3827] - Fix Cave rest service doesn't
retrieve the repositories
URL: https://github.com/apache/karaf-cave/pull/6#discussion_r150954730
 
 

 ##########
 File path: server/rest/src/main/java/org/apache/karaf/cave/server/rest/Repository.java
 ##########
 @@ -16,21 +16,145 @@
  */
 package org.apache.karaf.cave.server.rest;
 
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.xml.bind.annotation.XmlAccessType;
+import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlElement;
 import javax.xml.bind.annotation.XmlRootElement;
+import javax.xml.bind.annotation.XmlType;
 
 import org.apache.karaf.cave.server.api.CaveRepository;
+import org.apache.karaf.util.XmlUtils;
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+import org.w3c.dom.NodeList;
 
 @XmlRootElement(name = "cave-repository")
+@XmlAccessorType(XmlAccessType.NONE)
+@XmlType(name = "Repository", propOrder = {"name", "increment", "location", "resources"})
 public class Repository {
 
-    private final CaveRepository repository;
 
 Review comment:
   I don't change the implementation of the method in the Service class :
   ```
   public Repository getRepository(@PathParam("name") String name) {
           CaveRepository repository = service.getRepository(name);
           if (repository != null) {
               return new Repository(repository);
           } else {
               return null;
           }
   }
   ```
   repository service is passed in the constructor and used directly the retreive repository
data :
   ```
   public Repository(CaveRepository repository) {
           this.name = repository.getName();
           this.increment = repository.getIncrement();
           this.location = repository.getLocation();
   
           try {
   Document doc = XmlUtils.parse(repository.getRepositoryXml().toExternalForm());
   ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cave rest service doesn't retrieve the repositories
> ---------------------------------------------------
>
>                 Key: KARAF-3827
>                 URL: https://issues.apache.org/jira/browse/KARAF-3827
>             Project: Karaf
>          Issue Type: Bug
>          Components: cave-rest
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>             Fix For: cave-4.0.1
>
>
> Even if a repository exists:
> {code}
> karaf@root()> cave:repositories 
> Name          | Location
> -----------------------------------------------------------------------------
> my-repository | /home/jbonofre/bin/apache-karaf-4.0.0/data/cave/my-repository
> {code}
> accessing the Cave REST API on:
> {code}
> http://localhost:8181/cave/rest/repositories
> {code}
> just give:
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <cave-repositorys><cave-repository/></cave-repositorys>
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message