karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-5411) Client doesn't prompt for user if no user.properties file
Date Mon, 23 Oct 2017 05:54:00 GMT

    [ https://issues.apache.org/jira/browse/KARAF-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214678#comment-16214678
] 

ASF GitHub Bot commented on KARAF-5411:
---------------------------------------

jbonofre commented on a change in pull request #382: [KARAF-5411] Allow for users.properties
file not existing, or empty
URL: https://github.com/apache/karaf/pull/382#discussion_r146170622
 
 

 ##########
 File path: client/src/main/java/org/apache/karaf/client/Main.java
 ##########
 @@ -142,14 +142,28 @@ public String getUpdatedPassword(ClientSession session, String prompt,
String la
                     }
                 });
             }
+            
+            if (config.getUser()==null || config.getUser().isEmpty()) {
+            	while (true) {
+            		String user = console.readLine("Enter user : ");
 
 Review comment:
   In order to be consistent with the password prompt, I will use `"Enter user:  "`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Client doesn't prompt for user if no user.properties file
> ---------------------------------------------------------
>
>                 Key: KARAF-5411
>                 URL: https://issues.apache.org/jira/browse/KARAF-5411
>             Project: Karaf
>          Issue Type: Bug
>         Environment: 4.1.2, 4.2
>            Reporter: Tom Quarendon
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 4.2.0, 4.1.3
>
>
> If you have no etc/users.properties file, or have a users.properties file that is empty,
the client (bin/client) won't run, as it has no user.
> It would seem obvious to prompt for the username in these circumstances.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message