Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Tue, 12 Sep 2017 11:47:00 +0000 (UTC)
From: =?utf-8?Q?Jean-Baptiste_Onofr=C3=A9_=28JIRA=29?= <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.13101491.1505174607000.89840.1505216820229@Atlassian.JIRA>
In-Reply-To: <JIRA.13101491.1505174607000@Atlassian.JIRA>
References: <JIRA.13101491.1505174607000@Atlassian.JIRA> <JIRA.13101491.1505174607807@jira-lw-us.apache.org>
Subject: [jira] [Updated] (KARAF-5362) NPE creating session with a null "in"
 parameter from a SessionFactory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 12 Sep 2017 11:47:04 -0000


     [ https://issues.apache.org/jira/browse/KARAF-5362?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Onofr=C3=A9 updated KARAF-5362:
----------------------------------------
    Component/s: karaf-documentation

> NPE creating session with a null "in" parameter from a SessionFactory
> ---------------------------------------------------------------------
>
>                 Key: KARAF-5362
>                 URL: https://issues.apache.org/jira/browse/KARAF-5362
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-documentation, karaf-shell
>    Affects Versions: 4.1.2
>            Reporter: Emily Berk
>            Assignee: Jean-Baptiste Onofr=C3=A9
>            Priority: Trivial
>
> The javadoc for {{SessionFactory#create(InputStream, PrintStream, PrintSt=
ream)}} says
> {code:java}
> @param in the input stream, can be <code>null</code> if the session is on=
ly used to execute a command using {@link Session#execute(CharSequence)}
> {code}
> When I try
> {code:java}
> package org.apache.karaf.shell.impl.console;
> import static org.easymock.EasyMock.createMock;
> import java.io.PrintStream;
> import java.io.UnsupportedEncodingException;
> import org.apache.felix.service.threadio.ThreadIO;
> import org.apache.karaf.shell.api.console.SessionFactory;
> import org.junit.Test;
> public class SessionFactoryImplTest {
>    =20
>     @Test
>     public void createWithNullInputStream() throws UnsupportedEncodingExc=
eption {
>         final SessionFactory sessionFactory =3D new SessionFactoryImpl(cr=
eateMock(ThreadIO.class));
>         sessionFactory.create(null, createMock(PrintStream.class), create=
Mock(PrintStream.class));
>     }
> }
> {code}
> I get
> {code}
> java.lang.NullPointerException: "in" is null!
> =09at java.nio.channels.Channels.checkNotNull(Channels.java:67)
> =09at java.nio.channels.Channels.newChannel(Channels.java:347)
> =09at org.apache.felix.gogo.runtime.CommandSessionImpl.<init>(CommandSess=
ionImpl.java:108)
> =09at org.apache.felix.gogo.runtime.CommandProcessorImpl.createSession(Co=
mmandProcessorImpl.java:82)
> =09at org.apache.felix.gogo.runtime.CommandProcessorImpl.createSession(Co=
mmandProcessorImpl.java:38)
> =09at org.apache.karaf.shell.impl.console.HeadlessSessionImpl.<init>(Head=
lessSessionImpl.java:67)
> =09at org.apache.karaf.shell.impl.console.SessionFactoryImpl.create(Sessi=
onFactoryImpl.java:155)
> =09at org.apache.karaf.shell.impl.console.SessionFactoryImpl.create(Sessi=
onFactoryImpl.java:146)
> =09at org.apache.karaf.shell.impl.console.SessionFactoryImplTest.createWi=
thNullInputStream(SessionFactoryImplTest.java:41)
> {code}
> A work-around is to pass a non-null {{InputStream}} that should never be =
called if the {{Session}} is only used to execute a command using {{Session=
#execute(CharSequence)}}.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)