Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC582200CF0 for ; Mon, 21 Aug 2017 18:06:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CB5191655FC; Mon, 21 Aug 2017 16:06:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 266761655FF for ; Mon, 21 Aug 2017 18:06:06 +0200 (CEST) Received: (qmail 73607 invoked by uid 500); 21 Aug 2017 16:06:05 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 73594 invoked by uid 99); 21 Aug 2017 16:06:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Aug 2017 16:06:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3DDA3180702 for ; Mon, 21 Aug 2017 16:06:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.702 X-Spam-Level: X-Spam-Status: No, score=-98.702 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VLs3z4nRoflY for ; Mon, 21 Aug 2017 16:06:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5B8C861131 for ; Mon, 21 Aug 2017 16:06:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 77E49E0EA7 for ; Mon, 21 Aug 2017 16:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AF08D25391 for ; Mon, 21 Aug 2017 16:06:00 +0000 (UTC) Date: Mon, 21 Aug 2017 16:06:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-5314) The performance of profile builder used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 21 Aug 2017 16:06:07 -0000 [ https://issues.apache.org/jira/browse/KARAF-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135364#comment-16135364 ] ASF subversion and git services commented on KARAF-5314: -------------------------------------------------------- Commit b22e3c44cdd09edbf6f1bff4199826fc98a3f405 in karaf's branch refs/heads/karaf-4.1.x from [~chris@die-schneider.net] [ https://git-wip-us.apache.org/repos/asf?p=karaf.git;h=b22e3c4 ] [KARAF-5314] Only recurse into dependencies once per feature > The performance of profile builder used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0 > -------------------------------------------------------------------------------------------------------------- > > Key: KARAF-5314 > URL: https://issues.apache.org/jira/browse/KARAF-5314 > Project: Karaf > Issue Type: Bug > Reporter: Vinay Shankar > Fix For: 4.2.0 > > > The performance of profile builder used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0. > The java streams API is being used in 4.1 to filter our the required features from the set of all features present in the repositories that are part of the profile. This is done in the "addFeatures" method in the "Builder.java" class in the "org.apache.karaf.profile.core" bundle. This change (from 4.0) has drastically reduced the performance. For a profile with ~900 features in all the repositories in the profile and ~300 required features from a highly complex feature dependency tree, this function is taking around 13min to complete. The same execution took around 3-5min in 4.0 (where simple for loops were being used). -- This message was sent by Atlassian JIRA (v6.4.14#64029)