Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Sun, 20 Aug 2017 13:57:02 +0000 (UTC)
From: "Christian Schneider (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.13095636.1503063405000.74236.1503237422001@Atlassian.JIRA>
In-Reply-To: <JIRA.13095636.1503063405000@Atlassian.JIRA>
References: <JIRA.13095636.1503063405000@Atlassian.JIRA> <JIRA.13095636.1503063405212@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KARAF-5314) The performance of profile builder
 used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 20 Aug 2017 13:57:10 -0000


    [ https://issues.apache.org/jira/browse/KARAF-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134430#comment-16134430 ] 

Christian Schneider commented on KARAF-5314:
--------------------------------------------

I just found a possible change that should speed up the code quite a lot. Currently we always recurse into every feature dependency. I think we we can make this a lot faster by only recursing into the dependencies of a feature once. 

> The performance of profile builder used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-5314
>                 URL: https://issues.apache.org/jira/browse/KARAF-5314
>             Project: Karaf
>          Issue Type: Bug
>            Reporter: Vinay Shankar
>             Fix For: 4.1.3
>
>
> The performance of profile builder used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0. 
> The java streams API is being used in 4.1 to filter our the required features from the set of all features present in the repositories that are part of the profile. This is done in the "addFeatures" method in the "Builder.java" class in the "org.apache.karaf.profile.core" bundle. This change (from 4.0) has drastically reduced the performance. For a profile with ~900 features in all the repositories in the profile and ~300 required features from a highly complex feature dependency tree, this function is taking around 13min to complete. The same execution took around 3-5min in 4.0 (where simple for loops were being used). 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)