Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Thu, 24 Aug 2017 12:41:00 +0000 (UTC)
From: "Grzegorz Grzybek (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.13095636.1503063405000.111149.1503578460470@Atlassian.JIRA>
In-Reply-To: <JIRA.13095636.1503063405000@Atlassian.JIRA>
References: <JIRA.13095636.1503063405000@Atlassian.JIRA> <JIRA.13095636.1503063405212@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KARAF-5314) The performance of profile builder
 used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 24 Aug 2017 12:41:09 -0000


    [ https://issues.apache.org/jira/browse/KARAF-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139985#comment-16139985 ] 

Grzegorz Grzybek commented on KARAF-5314:
-----------------------------------------

[~chris@die-schneider.net], I think this may be related:
{noformat}
[ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.2.0-SNAPSHOT:assembly (process-resources) on project jboss-fuse-karaf: Unable to build assembly: invalid version "3.2.0-SNAPSHOT": non-numeric "0-SNAPSHOT": For input string: "0-SNAPSHOT" -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.2.0-SNAPSHOT:assembly (process-resources) on project jboss-fuse-karaf: Unable to build assembly
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Unable to build assembly
	at org.apache.karaf.tooling.AssemblyMojo.execute(AssemblyMojo.java:283)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
	... 20 more
Caused by: java.lang.IllegalArgumentException: invalid version "3.2.0-SNAPSHOT": non-numeric "0-SNAPSHOT"
	at org.osgi.framework.Version.parseInt(Version.java:170)
	at org.osgi.framework.Version.<init>(Version.java:134)
	at org.apache.karaf.features.internal.service.FeatureReq.exactVersion(FeatureReq.java:69)
	at org.apache.karaf.features.internal.service.FeatureReq.range(FeatureReq.java:64)
	at org.apache.karaf.features.internal.service.FeatureReq.<init>(FeatureReq.java:45)
	at org.apache.karaf.profile.assembly.FeatureSelector.getMatching(FeatureSelector.java:77)
	at org.apache.karaf.profile.assembly.FeatureSelector.addFeatures(FeatureSelector.java:59)
	at org.apache.karaf.profile.assembly.FeatureSelector.addFeatures(FeatureSelector.java:66)
	at org.apache.karaf.profile.assembly.FeatureSelector.addFeatures(FeatureSelector.java:66)
	at org.apache.karaf.profile.assembly.FeatureSelector.getMatching(FeatureSelector.java:53)
	at org.apache.karaf.profile.assembly.Builder.bootStage(Builder.java:878)
	at org.apache.karaf.profile.assembly.Builder.doGenerateAssembly(Builder.java:673)
	at org.apache.karaf.profile.assembly.Builder.generateAssembly(Builder.java:446)
	at org.apache.karaf.tooling.AssemblyMojo.doExecute(AssemblyMojo.java:521)
	at org.apache.karaf.tooling.AssemblyMojo.execute(AssemblyMojo.java:277)
	... 22 more
Caused by: java.lang.NumberFormatException: For input string: "0-SNAPSHOT"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:580)
	at java.lang.Integer.parseInt(Integer.java:615)
	at org.osgi.framework.Version.parseInt(Version.java:168)
	... 36 more
{noformat}

I'm using SNAPSHOT features for CXF 3.2.0-SNAPSHOT...

> The performance of profile builder used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-5314
>                 URL: https://issues.apache.org/jira/browse/KARAF-5314
>             Project: Karaf
>          Issue Type: Bug
>            Reporter: Vinay Shankar
>            Assignee: Christian Schneider
>             Fix For: 4.2.0, 4.1.3
>
>
> The performance of profile builder used by karaf maven plugin has reduced significantly in 4.1 compared to 4.0. 
> The java streams API is being used in 4.1 to filter our the required features from the set of all features present in the repositories that are part of the profile. This is done in the "addFeatures" method in the "Builder.java" class in the "org.apache.karaf.profile.core" bundle. This change (from 4.0) has drastically reduced the performance. For a profile with ~900 features in all the repositories in the profile and ~300 required features from a highly complex feature dependency tree, this function is taking around 13min to complete. The same execution took around 3-5min in 4.0 (where simple for loops were being used). 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)