Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6A3C8200CAD for ; Mon, 15 May 2017 23:32:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 68C46160BA9; Mon, 15 May 2017 21:32:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8FE66160BD0 for ; Mon, 15 May 2017 23:32:11 +0200 (CEST) Received: (qmail 1611 invoked by uid 500); 15 May 2017 21:32:10 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 1239 invoked by uid 99); 15 May 2017 21:32:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 May 2017 21:32:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 318A0C096D for ; Mon, 15 May 2017 21:32:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GKhz5bnLNFlG for ; Mon, 15 May 2017 21:32:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 83F075FDCD for ; Mon, 15 May 2017 21:32:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9EE34E01A8 for ; Mon, 15 May 2017 21:32:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 188DD243AD for ; Mon, 15 May 2017 21:32:05 +0000 (UTC) Date: Mon, 15 May 2017 21:32:05 +0000 (UTC) From: "Christopher Lockard (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KARAF-5124) NPE when location information is included in console logging pattern MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 15 May 2017 21:32:12 -0000 [ https://issues.apache.org/jira/browse/KARAF-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Lockard updated KARAF-5124: --------------------------------------- Description: When including class and line in the console logger pattern a NPE is thrown when doing a log:tail or log:display. This appears to be a result of the KarafLogEvent not keeping the location information and the PatternParser not checking if location information is available before trying to use it. This is the pattern in org.apache.karaf.log.cfg that causes the NPE pattern = %d{ABSOLUTE} | %-5.5p | %-16.16t | %-40.40C %4L | %-20.20X{bundle.name} | %m%n This is the exception thrown Exception in thread "pool-28-thread-1" java.lang.NullPointerException at org.apache.karaf.log.core.internal.layout.PatternParser$ClassNamePatternConverter.getFullyQualifiedName(PatternParser.java:511) at org.apache.karaf.log.core.internal.layout.PatternParser$NamedPatternConverter.convert(PatternParser.java:482) at org.apache.karaf.log.core.internal.layout.PatternConverter.format(PatternConverter.java:63) at org.apache.karaf.log.core.internal.LogEventFormatterImpl.format(LogEventFormatterImpl.java:117) at org.apache.karaf.log.command.DisplayLog.printEvent(DisplayLog.java:121) at org.apache.karaf.log.command.DisplayLog.printEvent(DisplayLog.java:105) at org.apache.karaf.log.command.LogTail$PrintEventThread.run(LogTail.java:101) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) was: When including class and line in the console logger pattern a NPE is thrown when doing a log:tail or log:display. This appears to be a result of the KarafLogEvent not keeping the location information and the PatternParser not checking if location information is available before trying to use it. This is the pattern in org.apache.karaf.log.cfg that causes the NPE `pattern = %d{ABSOLUTE} | %-5.5p | %-16.16t | %-40.40C %4L | %-20.20X{bundle.name} | %m%n` This is the exception thrown Exception in thread "pool-28-thread-1" java.lang.NullPointerException at org.apache.karaf.log.core.internal.layout.PatternParser$ClassNamePatternConverter.getFullyQualifiedName(PatternParser.java:511) at org.apache.karaf.log.core.internal.layout.PatternParser$NamedPatternConverter.convert(PatternParser.java:482) at org.apache.karaf.log.core.internal.layout.PatternConverter.format(PatternConverter.java:63) at org.apache.karaf.log.core.internal.LogEventFormatterImpl.format(LogEventFormatterImpl.java:117) at org.apache.karaf.log.command.DisplayLog.printEvent(DisplayLog.java:121) at org.apache.karaf.log.command.DisplayLog.printEvent(DisplayLog.java:105) at org.apache.karaf.log.command.LogTail$PrintEventThread.run(LogTail.java:101) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) > NPE when location information is included in console logging pattern > -------------------------------------------------------------------- > > Key: KARAF-5124 > URL: https://issues.apache.org/jira/browse/KARAF-5124 > Project: Karaf > Issue Type: Bug > Affects Versions: 4.1.1 > Reporter: Christopher Lockard > Fix For: 4.1.2 > > > When including class and line in the console logger pattern a NPE is thrown when doing a log:tail or log:display. > This appears to be a result of the KarafLogEvent not keeping the location information and the PatternParser not checking if location information is available before trying to use it. > This is the pattern in org.apache.karaf.log.cfg that causes the NPE > pattern = %d{ABSOLUTE} | %-5.5p | %-16.16t | %-40.40C %4L | %-20.20X{bundle.name} | %m%n > This is the exception thrown > Exception in thread "pool-28-thread-1" java.lang.NullPointerException > at org.apache.karaf.log.core.internal.layout.PatternParser$ClassNamePatternConverter.getFullyQualifiedName(PatternParser.java:511) > at org.apache.karaf.log.core.internal.layout.PatternParser$NamedPatternConverter.convert(PatternParser.java:482) > at org.apache.karaf.log.core.internal.layout.PatternConverter.format(PatternConverter.java:63) > at org.apache.karaf.log.core.internal.LogEventFormatterImpl.format(LogEventFormatterImpl.java:117) > at org.apache.karaf.log.command.DisplayLog.printEvent(DisplayLog.java:121) > at org.apache.karaf.log.command.DisplayLog.printEvent(DisplayLog.java:105) > at org.apache.karaf.log.command.LogTail$PrintEventThread.run(LogTail.java:101) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) -- This message was sent by Atlassian JIRA (v6.3.15#6346)