karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Serge Huber (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (KARAF-4361) Allow dynamic config customization when embedding Karaf using the Main class
Date Wed, 15 Mar 2017 09:25:41 GMT

     [ https://issues.apache.org/jira/browse/KARAF-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Serge Huber reopened KARAF-4361:
--------------------------------

I just checked the status of the master branch and it seems this patch was not applied correctly
or was lost somehow ? It's missing the check in the launch method.

The karaf-4.0.x branch seems ok though.

> Allow dynamic config customization when embedding Karaf using the Main class
> ----------------------------------------------------------------------------
>
>                 Key: KARAF-4361
>                 URL: https://issues.apache.org/jira/browse/KARAF-4361
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-core
>    Affects Versions: 4.1.0, 4.0.4
>            Reporter: Serge Huber
>            Assignee: Guillaume Nodet
>             Fix For: 4.0.9, 4.1.1
>
>         Attachments: KARAF_4361_Allow_dynamic_config_customization_when_embedding_Karaf_using_the_Main_class.patch
>
>
> We are using Karaf by embedding it and basically starting it like this : 
> {code}
>             // code to setup System properties
>             main = new Main(new String[0]);
>             main.launch();
> {code}
> The problem is that the ConfigProperties that are used to startup Karaf are directly
created in the main.launch() method, like this:
> {code}
>     public void launch() throws Exception {
>         config = new ConfigProperties();
> {code}
> Ideally it would be great if we could either have a setter to provide the config value,
so that we could manipulate it before launching. In an embedded environment this quickly becomes
a necessity. For example we would like to make it possible to have retrieve properties coming
from another framework such as Spring and use those to override  config.properties settings
in a dynamic way, without needing to dump them to a file at Karaf startup. I'm aware of the
${includes} and ${optionals} but those require files to be read from the disk where here I'm
talking about being able to dynamically manipulate the properties once loaded.
> Basically something like this would be fantastic
> {code}
>             // code to setup System properties
>             main = new Main(new String[0]);
>             ConfigProperties config = main.getConfig();
>             if (config == null) {
>                config = new ConfigProperties();
>             }
>             // manipulate config in any way desired
>             main.setConfig(config)
>             main.launch();
> {code}
> The main.launch could then simply be modified to something like this : 
> {code}
>     public void launch() throws Exception {
>         if (config == null) {
>             config = new ConfigProperties();
>         }
> {code}
> Btw we are using Karaf 4.0.x so having this in both Karaf 4.1.0 and Karaf 4.0 would be
fantastic.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message