Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Fri, 10 Feb 2017 09:52:41 +0000 (UTC)
From: "Guillaume Nodet (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.12944523.1456414917000.47148.1486720361929@Atlassian.JIRA>
In-Reply-To: <JIRA.12944523.1456414917000@Atlassian.JIRA>
References: <JIRA.12944523.1456414917000@Atlassian.JIRA> <JIRA.12944523.1456414917746@jira-lw-us.apache.org>
Subject: [jira] [Resolved] (KARAF-4361) Allow dynamic config customization
 when embedding Karaf using the Main class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 10 Feb 2017 09:52:46 -0000


     [ https://issues.apache.org/jira/browse/KARAF-4361?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved KARAF-4361.
------------------------------------
    Resolution: Fixed
      Assignee: Guillaume Nodet  (was: Jean-Baptiste Onofr=C3=A9)

Thx for the patch !

> Allow dynamic config customization when embedding Karaf using the Main cl=
ass
> -------------------------------------------------------------------------=
---
>
>                 Key: KARAF-4361
>                 URL: https://issues.apache.org/jira/browse/KARAF-4361
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-core
>    Affects Versions: 4.1.0, 4.0.4
>            Reporter: Serge Huber
>            Assignee: Guillaume Nodet
>             Fix For: 4.0.9, 4.1.1
>
>         Attachments: KARAF_4361_Allow_dynamic_config_customization_when_e=
mbedding_Karaf_using_the_Main_class.patch
>
>
> We are using Karaf by embedding it and basically starting it like this :=
=20
> {code}
>             // code to setup System properties
>             main =3D new Main(new String[0]);
>             main.launch();
> {code}
> The problem is that the ConfigProperties that are used to startup Karaf a=
re directly created in the main.launch() method, like this:
> {code}
>     public void launch() throws Exception {
>         config =3D new ConfigProperties();
> {code}
> Ideally it would be great if we could either have a setter to provide the=
 config value, so that we could manipulate it before launching. In an embed=
ded environment this quickly becomes a necessity. For example we would like=
 to make it possible to have retrieve properties coming from another framew=
ork such as Spring and use those to override  config.properties settings in=
 a dynamic way, without needing to dump them to a file at Karaf startup. I'=
m aware of the ${includes} and ${optionals} but those require files to be r=
ead from the disk where here I'm talking about being able to dynamically ma=
nipulate the properties once loaded.
> Basically something like this would be fantastic
> {code}
>             // code to setup System properties
>             main =3D new Main(new String[0]);
>             ConfigProperties config =3D main.getConfig();
>             if (config =3D=3D null) {
>                config =3D new ConfigProperties();
>             }
>             // manipulate config in any way desired
>             main.setConfig(config)
>             main.launch();
> {code}
> The main.launch could then simply be modified to something like this :=20
> {code}
>     public void launch() throws Exception {
>         if (config =3D=3D null) {
>             config =3D new ConfigProperties();
>         }
> {code}
> Btw we are using Karaf 4.0.x so having this in both Karaf 4.1.0 and Karaf=
 4.0 would be fantastic.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)