Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Tue, 3 Jan 2017 18:27:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.13031723.1483467989000.630789.1483468078542@Atlassian.JIRA>
In-Reply-To: <JIRA.13031723.1483467989000@Atlassian.JIRA>
References: <JIRA.13031723.1483467989000@Atlassian.JIRA> <JIRA.13031723.1483467989656@arcas>
Subject: [jira] [Commented] (KARAF-4917) Support dynamicaliy registered
 configurations in RBAC
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 03 Jan 2017 18:28:00 -0000


    [ https://issues.apache.org/jira/browse/KARAF-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795747#comment-15795747 ] 

ASF GitHub Bot commented on KARAF-4917:
---------------------------------------

GitHub user zregvart opened a pull request:

    https://github.com/apache/karaf/pull/275

    KARAF-4917 Support dynamicaliy registered configurations in RBAC

    When adding configuration at runtime through
    `ConfigurationAdmin#createFactoryConfiguration` Apache Felix appends
    random UUID to the Configuration PID [1][2].
    
    In order for those to be considered by `getRequiredRoles` that random 
    UUID needs to be removed in comparison performed by `getGeneralPid`.
    
    [1] https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L397-L400
    [2] https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L1093-L1137

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zregvart/karaf master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #275
    
----
commit 0dbf67cbedf2e77a926121fedc506433ee43d21b
Author: Zoran Regvart <zoran@regvart.com>
Date:   2017-01-03T18:16:33Z

    Support dynamic configuration from ConfigAdmin
    
    When adding configuration at runtime through
    ConfigurationAdmin#createFactoryConfiguration Apache Felix appends
    random UUID to the Configuration PID [1][2]. In order for those to be
    considered by `getRequiredRoles` that random UUID needs to be removed in
    comparison performed by `getGeneralPid`.
    
    [1] https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L397-L400
    [2] https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L1093-L1137

----


> Support dynamicaliy registered configurations in RBAC
> -----------------------------------------------------
>
>                 Key: KARAF-4917
>                 URL: https://issues.apache.org/jira/browse/KARAF-4917
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-security
>    Affects Versions: 4.1.0
>            Reporter: Zoran Regvart
>            Priority: Minor
>
> When adding configuration at runtime through {{ConfigurationAdmin#createFactoryConfiguration}} Apache Felix appends [random|https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L397-L400] [UUID|https://github.com/apache/felix/blob/trunk/configadmin/src/main/java/org/apache/felix/cm/impl/ConfigurationManager.java#L1093-L1137] to the Configuration PID.
> In order for those to be considered by {{getRequiredRoles}} that random UUID needs to be removed in comparison performed by {{getGeneralPid}}.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)