Return-Path: <issues-return-32666-archive-asf-public=cust-asf.ponee.io@karaf.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id F2558200BD5
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  8 Dec 2016 21:54:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id F0EC3160B0A; Thu,  8 Dec 2016 20:54:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 44E80160B1F
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  8 Dec 2016 21:54:00 +0100 (CET)
Received: (qmail 18438 invoked by uid 500); 8 Dec 2016 20:53:59 -0000
Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@karaf.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@karaf.apache.org>
List-Post: <mailto:issues@karaf.apache.org>
List-Id: <issues.karaf.apache.org>
Reply-To: dev@karaf.apache.org
Delivered-To: mailing list issues@karaf.apache.org
Received: (qmail 18427 invoked by uid 99); 8 Dec 2016 20:53:59 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 20:53:59 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 2DF022C03E2
	for <issues@karaf.apache.org>; Thu,  8 Dec 2016 20:53:59 +0000 (UTC)
Date: Thu, 8 Dec 2016 20:53:59 +0000 (UTC)
From: "Dariush Amiri (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.13026785.1481230422000.476819.1481230439185@Atlassian.JIRA>
In-Reply-To: <JIRA.13026785.1481230422000@Atlassian.JIRA>
References: <JIRA.13026785.1481230422000@Atlassian.JIRA> <JIRA.13026785.1481230422110@arcas>
Subject: [jira] [Created] (KARAF-4885) Karaf does not gracefully handle a
 feature with a prerequisite feature that is already installed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 08 Dec 2016 20:54:01 -0000

Dariush Amiri created KARAF-4885:
------------------------------------

             Summary: Karaf does not gracefully handle a feature with a prerequisite feature that is already installed
                 Key: KARAF-4885
                 URL: https://issues.apache.org/jira/browse/KARAF-4885
             Project: Karaf
          Issue Type: Bug
    Affects Versions: 4.1.0
            Reporter: Dariush Amiri


Here is a project on github that reproduces this issue:
https://github.com/damiri-ts/karaf-features-issue

After more investigation, the root cause seems to be the inability of karaf to gracefully handle situations where a child feature has a prerequisite feature that is already installed as part of a parent feature. It's confusing so I've included the feature definition below. Note that the aries-blueprint feature shows up twice.

    <feature name="something-else" version="${project.version}" description="Something else">
        <feature prerequisite="true">jasypt-encryption</feature>
        <feature prerequisite="true">aries-blueprint</feature>
    </feature>

    <feature name="example" version="${project.version}" description="Example">
        <feature>framework</feature>
        <feature>wrap</feature>
        <feature>aries-blueprint</feature>
        <feature>shell</feature>
        <feature>shell-compat</feature>
        <feature>feature</feature>
        <feature>jaas</feature>
        <feature>ssh</feature>
        <feature>management</feature>
        <feature>bundle</feature>
        <feature>config</feature>
        <feature>deployer</feature>
        <feature>diagnostic</feature>
        <feature>instance</feature>
        <feature>kar</feature>
        <feature>log</feature>
        <feature>package</feature>
        <feature>service</feature>
        <feature>system</feature>

        <feature>scr</feature>
        <feature>jetty</feature>
        <feature>pax-http-whiteboard</feature>

        <feature>something-else</feature>
    </feature>

This manifests itself in the logs like this:

2016-12-05T18:23:57,843 | ERROR | FelixStartLevel  | 
Felix                            |  -  -  | Bundle org.objectweb.asm.all 
[54] Error locking mvn:org.ow2.asm/asm-all/6.0_ALPHA 
(java.lang.IllegalStateException: Bundle in unexpected state.)
java.lang.IllegalStateException: Bundle in unexpected state.
     at 
org.apache.felix.framework.Felix.acquireBundleLock(Felix.java:5272) [?:?]
     at 
org.apache.felix.framework.Felix.setBundleStartLevel(Felix.java:1524) [?:?]
     at 
org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:338) 
[?:?]
     at java.lang.Thread.run(Thread.java:745) [?:?]
2016-12-05T18:23:57,844 | INFO  | CM Configuration Updater 
(ManagedService Update: pid=[org.apache.cxf.osgi]) | 
TldScanner                       | 189 - org.ops4j.pax.web.pax-web-jsp - 
4.4.0 | found TLD bundle://189.0:0/META-INF/c.tld
2016-12-05T18:23:57,841 | ERROR | FelixDispatchQueue | 
all                              | 184 - org.objectweb.asm.all - 5.0.2 | 
FrameworkEvent ERROR - org.objectweb.asm.all
java.lang.IllegalStateException: Bundle in unexpected state.
     at 
org.apache.felix.framework.Felix.acquireBundleLock(Felix.java:5272) [?:?]
     at 
org.apache.felix.framework.Felix.setBundleStartLevel(Felix.java:1524) [?:?]
     at 
org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:338) 
[?:?]
     at java.lang.Thread.run(Thread.java:745) [?:?]




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)