Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9C7C1200B8B for ; Tue, 4 Oct 2016 14:30:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9B2F3160AC5; Tue, 4 Oct 2016 12:30:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AF369160AE9 for ; Tue, 4 Oct 2016 14:30:27 +0200 (CEST) Received: (qmail 11841 invoked by uid 500); 4 Oct 2016 12:30:21 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 11523 invoked by uid 99); 4 Oct 2016 12:30:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2016 12:30:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 235652C0B05 for ; Tue, 4 Oct 2016 12:30:21 +0000 (UTC) Date: Tue, 4 Oct 2016 12:30:21 +0000 (UTC) From: "Fabian Lange (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-4748) Make Felix Resolver Threads configurable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 04 Oct 2016 12:30:28 -0000 [ https://issues.apache.org/jira/browse/KARAF-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545228#comment-15545228 ] Fabian Lange commented on KARAF-4748: ------------------------------------- the synchronizationin org.apache.felix.resolver.ResolverImpl.EnhancedExecutor.EnhancedExecutor(Executor) doesnt look right to me. scary :( > Make Felix Resolver Threads configurable > ---------------------------------------- > > Key: KARAF-4748 > URL: https://issues.apache.org/jira/browse/KARAF-4748 > Project: Karaf > Issue Type: Bug > Reporter: Fabian Lange > Attachments: Screen Shot 2016-10-03 at 20.13.47.png, Screen Shot 2016-10-04 at 09.25.48.png, Screen Shot 2016-10-04 at 09.26.04.png, Screen Shot 2016-10-04 at 09.26.17.png, Screen Shot 2016-10-04 at 09.27.45.png, Screen Shot 2016-10-04 at 09.28.20.png, Screen Shot 2016-10-04 at 09.28.50.png, Screen Shot 2016-10-04 at 09.30.14.png, Screen Shot 2016-10-04 at 09.31.16.png, Screen Shot 2016-10-04 at 11.54.19.png > > > It was requested in https://issues.apache.org/jira/browse/FELIX-5247 to make the resolver threads configurable to avoid creating many threads by karaf. > It turns out Felix already has that feature, but Karaf is not using it: > https://github.com/apache/karaf/blob/karaf-4.0.x/features/core/src/main/java/org/apache/karaf/features/internal/osgi/Activator.java#L119 > Resolver resolver = new ResolverImpl(new Logger(Logger.LOG_INFO)); > I propose to configure and supply an Executor with the desired threads. As additional up, this prevents situations where there are unnecessary threads created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)