karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-4748) Make Felix Resolver Threads configurable
Date Mon, 03 Oct 2016 18:47:20 GMT

    [ https://issues.apache.org/jira/browse/KARAF-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15543110#comment-15543110
] 

ASF GitHub Bot commented on KARAF-4748:
---------------------------------------

GitHub user CodingFabian opened a pull request:

    https://github.com/apache/karaf/pull/246

    [KARAF-4748] Make Felix Resolver Threads configurable and reuse Executor

    By setting `resolverThreads` in `org.apache.karaf.features.cfg` one can
    influence the amount of threads that Felix resolver will use.
    This change also re-uses the same ExecutorService instead of creating a new
    one with every resolve() call.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingFabian/karaf KARAF-4748

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit c572608b1b5c90cc7089356111ad6c3ab19b0c02
Author: Fabian Lange <lange.fabian@gmail.com>
Date:   2016-10-03T18:44:07Z

    [KARAF-4748] Make Felix Resolver Threads configurable and reuse Executor
    
    By setting `resolverThreads` in `org.apache.karaf.features.cfg` one can
    influence the amount of threads that Felix resolver will use.
    This change also re-uses the same ExecutorService instead of creating a new
    one with every resolve() call.

----


> Make Felix Resolver Threads configurable
> ----------------------------------------
>
>                 Key: KARAF-4748
>                 URL: https://issues.apache.org/jira/browse/KARAF-4748
>             Project: Karaf
>          Issue Type: Bug
>            Reporter: Fabian Lange
>         Attachments: Screen Shot 2016-10-03 at 20.13.47.png
>
>
> It was requested in https://issues.apache.org/jira/browse/FELIX-5247 to make the resolver
threads configurable to avoid creating many threads by karaf.
> It turns out Felix already has that feature, but Karaf is not using it:
> https://github.com/apache/karaf/blob/karaf-4.0.x/features/core/src/main/java/org/apache/karaf/features/internal/osgi/Activator.java#L119
> Resolver resolver = new ResolverImpl(new Logger(Logger.LOG_INFO));
> I propose to configure and supply an Executor with the desired threads. As additional
up, this prevents situations where there are unnecessary threads created.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message