Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Mon, 22 Aug 2016 14:21:21 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.12595607.1340384223000.370668.1471875681207@Atlassian.JIRA>
In-Reply-To: <JIRA.12595607.1340384223000@Atlassian.JIRA>
References: <JIRA.12595607.1340384223000@Atlassian.JIRA> <JIRA.12595607.1340384223564@arcas>
Subject: [jira] [Commented] (KARAF-1583) karaf-maven-plugin ignores
 dependency on feature
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 22 Aug 2016 14:21:23 -0000


    [ https://issues.apache.org/jira/browse/KARAF-1583?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1543=
0847#comment-15430847 ]=20

ASF GitHub Bot commented on KARAF-1583:
---------------------------------------

GitHub user skitt opened a pull request:

    https://github.com/apache/karaf/pull/228

    [KARAF-1583] Add repository dependencies

    Any repository dependencies encountered while processing feature
    dependencies are added to the repositories. We track
    feature-repository correspondences and only add necessary repositories
    after processing all the features, so we end up adding repositories
    necessary to find feature dependencies, but nothing else.
   =20
    Repositories are tracked explicitly to allow later integration of
    repositories mentioned in pre-existing feature.xml files; this will
    allow large feature repositories to be used optimally.
   =20
    Signed-off-by: Stephen Kitt <skitt@redhat.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skitt/karaf karaf-1583

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #228
   =20
----
commit 64c681e56d8a21daa8d2ca3b83521c51dda77554
Author: Stephen Kitt <skitt@redhat.com>
Date:   2016-05-27T14:20:21Z

    [KARAF-1583] Add repository dependencies
   =20
    Any repository dependencies encountered while processing feature
    dependencies are added to the repositories. We track
    feature-repository correspondences and only add necessary repositories
    after processing all the features, so we end up adding repositories
    necessary to find feature dependencies, but nothing else.
   =20
    Repositories are tracked explicitly to allow later integration of
    repositories mentioned in pre-existing feature.xml files; this will
    allow large feature repositories to be used optimally.
   =20
    Signed-off-by: Stephen Kitt <skitt@redhat.com>

----


> karaf-maven-plugin ignores dependency on feature
> ------------------------------------------------
>
>                 Key: KARAF-1583
>                 URL: https://issues.apache.org/jira/browse/KARAF-1583
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-tooling
>    Affects Versions: 3.0.0.RC1
>            Reporter: Brian Topping
>            Assignee: Jean-Baptiste Onofr=C3=A9
>
> When a project has a dependency on a feature, the dependency should be re=
ndered in the features.xml generated by {{karaf-maven-plugin:features-gener=
ate-descriptor}} as a {{<repository>}} element. =20
> I thought I added this, but it must have gotten lost in the patches and w=
ill submit another patch after KARAF-1537 is applied.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)