karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-884) karaf-maven-plugin should more closely map to POMs
Date Fri, 03 Jun 2016 15:50:59 GMT

    [ https://issues.apache.org/jira/browse/KARAF-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314293#comment-15314293
] 

ASF GitHub Bot commented on KARAF-884:
--------------------------------------

GitHub user skitt opened a pull request:

    https://github.com/apache/karaf/pull/195

    [KARAF-884] Generate feature dependencies

    Currently, POMs containing feature dependencies (classifier "features"
    and type "xml") produce features listing all the required bundles.
    This patch causes feature generation to represent feature dependencies
    using <feature/> elements instead.
    
    As a side-effect, aggregate features produce a new aggregate feature
    containing all the generated features.
    
    Signed-off-by: Stephen Kitt <skitt@redhat.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skitt/karaf feature-dependencies

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit 80b5245391afc8da888fa9468a4538d941e38c80
Author: Stephen Kitt <skitt@redhat.com>
Date:   2016-06-02T14:38:32Z

    [KARAF-884] Generate feature dependencies
    
    Currently, POMs containing feature dependencies (classifier "features"
    and type "xml") produce features listing all the required bundles.
    This patch causes feature generation to represent feature dependencies
    using <feature/> elements instead.
    
    As a side-effect, aggregate features produce a new aggregate feature
    containing all the generated features.
    
    Signed-off-by: Stephen Kitt <skitt@redhat.com>

----


> karaf-maven-plugin should more closely map to POMs
> --------------------------------------------------
>
>                 Key: KARAF-884
>                 URL: https://issues.apache.org/jira/browse/KARAF-884
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-tooling
>    Affects Versions: 3.0.0
>            Reporter: Brian Topping
>
> If karaf-maven-plugin is run against a set of POMs, the output of a feature generated
for a given project seems to be the transitive closure of the dependencies in the form of
a <bundle> entry for each dependency of the project.  This seems incorrect though. 
Consider if a parent project P builds A and B where A depends on X, B depends on A and Y.
 Currently, the feature for A will be a single bundle entry for X and the feature for B will
be three bundle entries for A, X & Y.  
> It seems to make more sense that the feature for B would actually be one <feature>
entry for A and a <bundle> entry for Y.  The <bundle> for X would be transitively
found through the feature definition for A.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message