karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-4523) JMXSecurityMBean bulk canInvoke should be robust even if bulkQuery contains duplicate operations
Date Tue, 10 May 2016 02:38:12 GMT

    [ https://issues.apache.org/jira/browse/KARAF-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277506#comment-15277506
] 

ASF GitHub Bot commented on KARAF-4523:
---------------------------------------

GitHub user tadayosi opened a pull request:

    https://github.com/apache/karaf/pull/182

    [KARAF-4523] JMXSecurityMBean bulk canInvoke should be robust even if bulkQuery contains
duplicate operations

    https://issues.apache.org/jira/browse/KARAF-4523

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tadayosi/karaf KARAF-4523

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #182
    
----
commit 1fff0131967ac11b0a481f503fbc952f777fc30d
Author: Tadayoshi Sato <sato.tadayoshi@gmail.com>
Date:   2016-05-10T02:32:34Z

    [KARAF-4523] JMXSecurityMBean bulk canInvoke should be robust even if bulkQuery contains
duplicate operations
    
    This fix is based on the original patch by Grzegorz Grzybek

----


> JMXSecurityMBean bulk canInvoke should be robust even if bulkQuery contains duplicate
operations
> ------------------------------------------------------------------------------------------------
>
>                 Key: KARAF-4523
>                 URL: https://issues.apache.org/jira/browse/KARAF-4523
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-management
>    Affects Versions: 4.0.5
>            Reporter: Tadayoshi Sato
>
> {{JMXSecurityMBean#canInvoke(Map<String, List<String>>)}} method throws the
following exception in the presence of duplicate operations in the {{bulkQuery}} parameter:
> {code}
> javax.management.openmbean.KeyAlreadyExistsException: Argument value's index, calculated
according to this TabularData instance's tabularType, already refers to a value in this table.
> 	at javax.management.openmbean.TabularDataSupport.checkValueAndIndex(TabularDataSupport.java:898)
> 	at javax.management.openmbean.TabularDataSupport.internalPut(TabularDataSupport.java:358)
> 	at javax.management.openmbean.TabularDataSupport.put(TabularDataSupport.java:350)
> 	at org.apache.karaf.management.internal.JMXSecurityMBeanImpl.canInvoke(JMXSecurityMBeanImpl.java:102)
> 	...
> {code}
> There is an improvement (KARAF-1300) that addressed a similar situlation in a different
component, so why not make {{JMXSecurityMBean}} robust as well?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message