karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-1583) karaf-maven-plugin ignores dependency on feature
Date Thu, 19 May 2016 13:23:12 GMT

    [ https://issues.apache.org/jira/browse/KARAF-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291083#comment-15291083
] 

ASF GitHub Bot commented on KARAF-1583:
---------------------------------------

GitHub user skitt opened a pull request:

    https://github.com/apache/karaf/pull/187

    Improve feature construction in karaf-maven-plugin

    This adds the following features when processing a Maven project to
    produce a feature:
    * features the project depends on are processed first, so their
      dependencies can be taken into account;
    * transitively-depended-on features are loaded;
    * bundles are only added if the included features don't already
      include them;
    * when not aggregating, features are added to the repositories
      (de-duplicated) [KARAF-1583].
    
    Signed-off-by: Stephen Kitt <skitt@redhat.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skitt/karaf karaf-3-features

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit 689bd1da353b0c90a56e52ec1620b3791b627986
Author: Stephen Kitt <skitt@redhat.com>
Date:   2016-05-19T09:35:31Z

    Improve feature construction in karaf-maven-plugin
    
    This adds the following features when processing a Maven project to
    produce a feature:
    * features the project depends on are processed first, so their
      dependencies can be taken into account;
    * transitively-depended-on features are loaded;
    * bundles are only added if the included features don't already
      include them;
    * when not aggregating, features are added to the repositories
      (de-duplicated) [KARAF-1583].
    
    Signed-off-by: Stephen Kitt <skitt@redhat.com>

----


> karaf-maven-plugin ignores dependency on feature
> ------------------------------------------------
>
>                 Key: KARAF-1583
>                 URL: https://issues.apache.org/jira/browse/KARAF-1583
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-tooling
>    Affects Versions: 3.0.0.RC1
>            Reporter: Brian Topping
>            Assignee: Jean-Baptiste Onofré
>
> When a project has a dependency on a feature, the dependency should be rendered in the
features.xml generated by {{karaf-maven-plugin:features-generate-descriptor}} as a {{<repository>}}
element.  
> I thought I added this, but it must have gotten lost in the patches and will submit another
patch after KARAF-1537 is applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message