karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-4374) Problems in Karaf start script
Date Wed, 02 Mar 2016 16:29:18 GMT

    [ https://issues.apache.org/jira/browse/KARAF-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175882#comment-15175882
] 

ASF GitHub Bot commented on KARAF-4374:
---------------------------------------

GitHub user lkiesow opened a pull request:

    https://github.com/apache/karaf/pull/160

    KARAF-4374, Fix problems in Karaf start script

    This commit fixes most of the problems pointed out by shellcheck [1] in
    the karaf start script (bin/karaf). These include:
    
     - Properly quote variables to prevent spaces from breaking the script
     - Ensure that KARAF_HOME is set for commands which would otherwise try
       to delete parts of the root file system. E.g: `rm -rf "$KARAF_HOME/lib"`
     - Use only $(..) instead of both $(...) and \`...\`
     - Require bash since not all commands are posix compliant anyway.
    
    [1] http://shellcheck.net

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lkiesow/karaf start-script

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #160
    
----
commit 700c8a15fe11f5f5d420eed826eec4caa5530a98
Author: Lars Kiesow <lkiesow@uos.de>
Date:   2016-03-02T15:34:07Z

    Fix problems in Karaf start script
    
    This commit fixes most of the problems pointed out by shellcheck [1] in
    the karaf start script (bin/karaf). These include:
    
     - Properly quote variables to prevent spaces from breaking the script
     - Ensure that KARAF_HOME is set for commands which would otherwise try
       to delete parts of the root file system. E.g:
           rm -rf "$KARAF_HOME/lib"
     - Use only $(..) instead of both $(...) and `...`
     - Require bash since not all commands are posix compliant anyway.
    
    [1] http://shellcheck.net
    
    Signed-off-by: Lars Kiesow <lkiesow@uos.de>

----


> Problems in Karaf start script
> ------------------------------
>
>                 Key: KARAF-4374
>                 URL: https://issues.apache.org/jira/browse/KARAF-4374
>             Project: Karaf
>          Issue Type: Bug
>    Affects Versions: 4.0.4
>            Reporter: Lars Kiesow
>
> There are a couple of problems pointed out by shellcheck [1] in the karaf start script
(bin/karaf). These include:
>     
>  - Properly quote variables to prevent spaces from breaking the script
>  - Ensure that KARAF_HOME is set for commands which would otherwise try
>    to delete parts of the root file system. E.g: `rm -rf "$KARAF_HOME/lib"`
>  - Use only $(..) instead of both $(...) and `...`
>  - Require bash since not all commands are posix compliant anyway.
> [1] http://shellcheck.net



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message