Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD1F41899A for ; Wed, 17 Feb 2016 16:18:49 +0000 (UTC) Received: (qmail 23417 invoked by uid 500); 17 Feb 2016 16:11:18 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 23378 invoked by uid 500); 17 Feb 2016 16:11:18 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 22912 invoked by uid 99); 17 Feb 2016 16:11:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2016 16:11:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 899152C1F58 for ; Wed, 17 Feb 2016 16:11:18 +0000 (UTC) Date: Wed, 17 Feb 2016 16:11:18 +0000 (UTC) From: =?utf-8?Q?Jean-Baptiste_Onofr=C3=A9_=28JIRA=29?= To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KARAF-4288) karaf-maven-plugin doesn't pass custom settings.xml option onto pax-url-aether MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-4288?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofr=C3=A9 updated KARAF-4288: ---------------------------------------- Fix Version/s: 4.0.5 4.1.0 > karaf-maven-plugin doesn't pass custom settings.xml option onto pax-url-a= ether > -------------------------------------------------------------------------= ----- > > Key: KARAF-4288 > URL: https://issues.apache.org/jira/browse/KARAF-4288 > Project: Karaf > Issue Type: Bug > Components: karaf-tooling > Affects Versions: 4.0.4 > Reporter: Stuart McCulloch > Assignee: Jean-Baptiste Onofr=C3=A9 > Fix For: 4.1.0, 4.0.5 > > Attachments: KARAF-4288.patch > > > When adding features to a custom distribution karaf-maven-plugin uses pax= -url-aether to fetch artifacts which don't yet exist in the local maven rep= ository. > pax-url-aether has logic to discover the local repository and settings.xm= l file, but this relies on defaults plus a few heuristics. If a Maven build= uses a custom settings.xml file which contains auth details, ie. when runn= ing on CI, then this is not picked up by pax-url-aether and it cannot fetch= down additional content. > The current user settings file is accessible from the MavenSession which = is already available in Karaf's MojoSupport: > MavenSession->getRequest->getUserSettingsFile > All that needs to be done is to pass this path to pax-url-aether by setti= ng the "org.ops4j.pax.url.mvn.settings" system property. Note the custom us= er settings file may be null or may not exist, in which case pax-url-aether= should use the global settings. Since it already has code to discover the = global settings using known locations we don't need to pass this on, so we = just avoid setting "org.ops4j.pax.url.mvn.settings" in this case. > (I'll attach a patch that implements this suggested solution) -- This message was sent by Atlassian JIRA (v6.3.4#6332)