Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 241C9189D2 for ; Sun, 10 Jan 2016 12:42:40 +0000 (UTC) Received: (qmail 21830 invoked by uid 500); 10 Jan 2016 12:42:40 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 21799 invoked by uid 500); 10 Jan 2016 12:42:40 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 21787 invoked by uid 99); 10 Jan 2016 12:42:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jan 2016 12:42:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C20D02C14F7 for ; Sun, 10 Jan 2016 12:42:39 +0000 (UTC) Date: Sun, 10 Jan 2016 12:42:39 +0000 (UTC) From: "Fabian Lange (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-4255) karaf-maven-plugin does include unused feature conditional dependencies in assembly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091020#comment-15091020 ] Fabian Lange commented on KARAF-4255: ------------------------------------- My PR works for assembly, but it seems that also during runtime the conditionals are not evaluated correctly, because when starting karaf the excluded bundles (e.g. mvn:org.apache.felix/org.apache.felix.webconsole.plugins.ds/2.0.2) are still installed (then from internet not system folder) > karaf-maven-plugin does include unused feature conditional dependencies in assembly > ----------------------------------------------------------------------------------- > > Key: KARAF-4255 > URL: https://issues.apache.org/jira/browse/KARAF-4255 > Project: Karaf > Issue Type: Bug > Affects Versions: 4.0.3 > Reporter: Fabian Lange > > I am using karaf-maven-plugin to make a custom assembly. > I do include SCR, but I do not include webconsole. > When I look into the system folder of my generated assembly, I can see: > {code} > target/assembly/system/org/apache/felix/org.apache.felix.webconsole.plugins.ds/2.0.2/org.apache.felix.webconsole.plugins.ds-2.0.2.jar > {code} > this correlates to the maven output: > {code} > [INFO] Feature scr is defined as a boot feature > [INFO] == Installing artifact mvn:org.apache.karaf.scr/org.apache.karaf.scr.command/4.0.3 > [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.scr/2.0.2 > [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.scr.compat/1.0.2 > [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.webconsole.plugins.ds/2.0.2 > [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.metatype/1.1.2 > [INFO] == Installing artifact mvn:org.apache.karaf.scr/org.apache.karaf.scr.management/4.0.3 > {code} > however looking at: https://github.com/apache/karaf/blob/master/assemblies/features/standard/src/main/feature/feature.xml#L524 > you can see that this is an conditional dependency only. > This is caused by the fact that assembly does not check if the conditional had been met: > https://github.com/apache/karaf/blob/master/profile/src/main/java/org/apache/karaf/profile/assembly/Builder.java#L822 > I believe we need a check for the conditionals wether the condition is actually met. -- This message was sent by Atlassian JIRA (v6.3.4#6332)