Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 862A5182A9 for ; Thu, 28 Jan 2016 10:34:55 +0000 (UTC) Received: (qmail 20749 invoked by uid 500); 28 Jan 2016 10:34:40 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 20650 invoked by uid 500); 28 Jan 2016 10:34:40 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 20409 invoked by uid 99); 28 Jan 2016 10:34:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jan 2016 10:34:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 37F372C1F5D for ; Thu, 28 Jan 2016 10:34:40 +0000 (UTC) Date: Thu, 28 Jan 2016 10:34:40 +0000 (UTC) From: "Martin Lichtin (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-3551) Extend Karaf Instance interface with getRmiRegistryHost, getRmiServerHost, getSshHost MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-3551?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1512= 1188#comment-15121188 ]=20 Martin Lichtin commented on KARAF-3551: --------------------------------------- I'd return the values that are either in org.apache.karaf.management.cfg or= org.apache.karaf.shell.cfg just like you already do it for the ports in InstanceServiceImpl. {code} int getInstanceSshPort(String name) { return getKarafPort(name, "etc/org.apache.karaf.shell.cfg", "sshPor= t"); } int getInstanceRmiRegistryPort(String name) { return getKarafPort(name, "etc/org.apache.karaf.management.cfg", "r= miRegistryPort"); } int getInstanceRmiServerPort(String name) { return getKarafPort(name, "etc/org.apache.karaf.management.cfg", "r= miServerPort"); } {code} Of course this will return 0.0.0.0 in most cases. But for this interface, I= 'd say, it is what you'd expect. > Extend Karaf Instance interface with getRmiRegistryHost, getRmiServerHost= , getSshHost > -------------------------------------------------------------------------= ------------ > > Key: KARAF-3551 > URL: https://issues.apache.org/jira/browse/KARAF-3551 > Project: Karaf > Issue Type: Improvement > Components: karaf-instance > Affects Versions: 3.0.3 > Reporter: Martin Lichtin > Assignee: Jean-Baptiste Onofr=C3=A9 > Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)