karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-3798) FeaturesServiceImpl not threadsafe
Date Tue, 26 Jan 2016 21:56:39 GMT

    [ https://issues.apache.org/jira/browse/KARAF-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118133#comment-15118133
] 

ASF GitHub Bot commented on KARAF-3798:
---------------------------------------

GitHub user CodingFabian opened a pull request:

    https://github.com/apache/karaf/pull/138

    KARAF-3798 - Use a single threaded executor for FeaturesService

    prevents potential concurrent installations, each provision is queued on
    a single executor thread.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingFabian/karaf single_threaded_features_service

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
    
----
commit d3b31064605529d97bcb490ffc89865cb74d8d3c
Author: Fabian Lange <lange.fabian@gmail.com>
Date:   2016-01-26T21:56:04Z

    KARAF-3798 - Use a single threaded executor for FeaturesService
    
    prevents potential concurrent installations, each provision is queued on
    a single executor thread.

----


> FeaturesServiceImpl not threadsafe
> ----------------------------------
>
>                 Key: KARAF-3798
>                 URL: https://issues.apache.org/jira/browse/KARAF-3798
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-feature
>    Affects Versions: 4.0.0.M3
>            Reporter: Fabian Lange
>
> This error happens pretty frequently with M3, when there are multiple features installed
on startup and config files to activate them created.
> {code}
> 2015-06-19 15:55:12,249 | ERROR | 43-3aaf88a7bd8b) | configadmin                    
 | 3 - org.apache.felix.configadmin - 1.8.4 | Unexpected problem delivering configuration
event to [org.osgi.service.cm.ConfigurationListener, id=30, bundle=9/mvn:org.apache.felix/org.apache.felix.scr/1.8.2]
> java.lang.NullPointerException
> 	at org.apache.felix.scr.impl.config.ConfigurationSupport.configurationEvent(ConfigurationSupport.java:283)[9:org.apache.felix.scr:1.8.2]
> 	at org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.sendEvent(ConfigurationManager.java:2036)[3:org.apache.felix.configadmin:1.8.4]
> 	at org.apache.felix.cm.impl.ConfigurationManager$FireConfigurationEvent.run(ConfigurationManager.java:2005)[3:org.apache.felix.configadmin:1.8.4]
> 	at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:103)[3:org.apache.felix.configadmin:1.8.4]
> 	at java.lang.Thread.run(Thread.java:745)[:1.8.0_40]
> {code}
> As written in latest comment, the root cause seems to be that multiple installFeature
calls to FeatureService mess up the state of the bundles. In my case it left a bundle in a
corrupt state, which was noticed when the configuration change did not really activate the
service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message