[ https://issues.apache.org/jira/browse/KARAF-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121188#comment-15121188
]
Martin Lichtin commented on KARAF-3551:
---------------------------------------
I'd return the values that are either in org.apache.karaf.management.cfg or org.apache.karaf.shell.cfg
just like you already do it for the ports in InstanceServiceImpl.
{code}
int getInstanceSshPort(String name) {
return getKarafPort(name, "etc/org.apache.karaf.shell.cfg", "sshPort");
}
int getInstanceRmiRegistryPort(String name) {
return getKarafPort(name, "etc/org.apache.karaf.management.cfg", "rmiRegistryPort");
}
int getInstanceRmiServerPort(String name) {
return getKarafPort(name, "etc/org.apache.karaf.management.cfg", "rmiServerPort");
}
{code}
Of course this will return 0.0.0.0 in most cases. But for this interface, I'd say, it is what
you'd expect.
> Extend Karaf Instance interface with getRmiRegistryHost, getRmiServerHost, getSshHost
> -------------------------------------------------------------------------------------
>
> Key: KARAF-3551
> URL: https://issues.apache.org/jira/browse/KARAF-3551
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-instance
> Affects Versions: 3.0.3
> Reporter: Martin Lichtin
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|