Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 129441830C for ; Sun, 27 Dec 2015 11:44:50 +0000 (UTC) Received: (qmail 88391 invoked by uid 500); 27 Dec 2015 11:44:50 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 88353 invoked by uid 500); 27 Dec 2015 11:44:49 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 88327 invoked by uid 99); 27 Dec 2015 11:44:49 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Dec 2015 11:44:49 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AB8722C1F54 for ; Sun, 27 Dec 2015 11:44:49 +0000 (UTC) Date: Sun, 27 Dec 2015 11:44:49 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-4199) Privacy Violation: Heap Inspection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072123#comment-15072123 ] ASF GitHub Bot commented on KARAF-4199: --------------------------------------- GitHub user oscerd opened a pull request: https://github.com/apache/karaf/pull/123 [KARAF-4199] Privacy Violation: Heap Inspection Hi all, This PR is related to: https://issues.apache.org/jira/browse/KARAF-4199 Andrea You can merge this pull request into a Git repository by running: $ git pull https://github.com/oscerd/karaf KARAF-4199 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/karaf/pull/123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #123 ---- commit 0cf9ed85d31f9f7fc4d5c4e1a9eff1fc50f188e7 Author: Andrea Cosentino Date: 2015-12-27T11:41:34Z [KARAF-4199] Privacy Violation: Heap Inspection ---- > Privacy Violation: Heap Inspection > ---------------------------------- > > Key: KARAF-4199 > URL: https://issues.apache.org/jira/browse/KARAF-4199 > Project: Karaf > Issue Type: Bug > Affects Versions: 4.0.3 > Reporter: Eduardo Aguinaga > > HP Fortify and SciTools Understand were used to perform an application security scan on the karaf source code. > The method interactive() in Main.java stores sensitive data in a String object on line 127, making it impossible to reliably purge the data from memory. > Main.java, lines 120-137: > {code} > 120 public String[] interactive(String destination, String name, String instruction, String[] prompt, boolean[] echo) { > 121 String[] answers = new String[prompt.length]; > 122 try { > 123 for (int i = 0; i < prompt.length; i++) { > 124 if (echo[i]) { > 125 answers[i] = console.readLine(prompt[i] + " "); > 126 } else { > 127 answers[i] = new String(console.readPassword(prompt[i] + " ")); > 128 } > 129 if (answers[i] == null) { > 130 return null; > 131 } > 132 } > 133 return answers; > 134 } catch (IOError e) { > 135 return null; > 136 } > 137 } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)