karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-4199) Privacy Violation: Heap Inspection
Date Sun, 27 Dec 2015 11:44:49 GMT

    [ https://issues.apache.org/jira/browse/KARAF-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072123#comment-15072123
] 

ASF GitHub Bot commented on KARAF-4199:
---------------------------------------

GitHub user oscerd opened a pull request:

    https://github.com/apache/karaf/pull/123

    [KARAF-4199] Privacy Violation: Heap Inspection

    Hi all,
    
    This PR is related to:
    https://issues.apache.org/jira/browse/KARAF-4199
    
    Andrea

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oscerd/karaf KARAF-4199

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
    
----
commit 0cf9ed85d31f9f7fc4d5c4e1a9eff1fc50f188e7
Author: Andrea Cosentino <ancosen@gmail.com>
Date:   2015-12-27T11:41:34Z

    [KARAF-4199] Privacy Violation: Heap Inspection

----


> Privacy Violation: Heap Inspection
> ----------------------------------
>
>                 Key: KARAF-4199
>                 URL: https://issues.apache.org/jira/browse/KARAF-4199
>             Project: Karaf
>          Issue Type: Bug
>    Affects Versions: 4.0.3
>            Reporter: Eduardo Aguinaga
>
> HP Fortify and SciTools Understand were used to perform an application security scan
on the karaf source code.
> The method interactive() in Main.java stores sensitive data in a String object on line
127, making it impossible to reliably purge the data from memory.
> Main.java, lines 120-137:
> {code}
> 120 public String[] interactive(String destination, String name, String instruction,
String[] prompt, boolean[] echo) {
> 121     String[] answers = new String[prompt.length];
> 122     try {
> 123         for (int i = 0; i < prompt.length; i++) {
> 124             if (echo[i]) {
> 125                 answers[i] = console.readLine(prompt[i] + " ");
> 126             } else {
> 127                 answers[i] = new String(console.readPassword(prompt[i] + " "));
> 128             }
> 129             if (answers[i] == null) {
> 130                 return null;
> 131             }
> 132         }
> 133         return answers;
> 134     } catch (IOError e) {
> 135         return null;
> 136     }
> 137 }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message