Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Fri, 9 Oct 2015 13:05:27 +0000 (UTC)
From: =?utf-8?Q?Jean-Baptiste_Onofr=C3=A9_=28JIRA=29?= <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.12860731.1441038774000.68429.1444395927421@Atlassian.JIRA>
In-Reply-To: <JIRA.12860731.1441038774000@Atlassian.JIRA>
References: <JIRA.12860731.1441038774000@Atlassian.JIRA>
 <JIRA.12860731.1441038774146@arcas>
Subject: [jira] [Commented] (KARAF-3964) cygpath call in "start" to convert
 CLASSPATH should first verify it's set
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/KARAF-3964?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1495=
0345#comment-14950345 ]=20

Jean-Baptiste Onofr=C3=A9 commented on KARAF-3964:
---------------------------------------------

Fixed on karaf-3.0.x: https://git-wip-us.apache.org/repos/asf?p=3Dkaraf.git=
;a=3Dcommitdiff;h=3D8b616f9f763f1d96d19c36d4abf248294f0d3b3b

> cygpath call in "start" to convert CLASSPATH should first verify it's set
> -------------------------------------------------------------------------
>
>                 Key: KARAF-3964
>                 URL: https://issues.apache.org/jira/browse/KARAF-3964
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-core
>         Environment: Windows 7, Cygwin
>            Reporter: David M. Karr
>            Assignee: Jean-Baptiste Onofr=C3=A9
>            Priority: Trivial
>             Fix For: 4.0.2, 3.0.6
>
>
> Several of the Karaf scripts have "if $cygwin" blocks that convert some v=
ariables to Windows form. If the variable referenced is not set, cygpath wi=
ll fail with "cygpath: can't convert empty path".  The impact is debatable,=
 as the variable after the command will be unset, same as before it, but th=
e error message can be confusing for users.
> Most of these cases are likely dealt with, but one that is not is in the =
"start" script, for the "CLASSPATH" variable.  I don't set a global CLASSPA=
TH value, and I believe it's generally a bad idea to set one.
> The most reasonable fix is to simply not run cygpath if CLASSPATH is not =
set or is empty.  Therefore, change this:
> CLASSPATH=3D`cygpath --path --windows "$CLASSPATH"`
> to:
> if [ ! -z "$CLASSPATH" ]; then
>     CLASSPATH=3D`cygpath --path --windows "$CLASSPATH"`
> fi


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)