Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Fri, 9 Oct 2015 12:35:26 +0000 (UTC)
From: =?utf-8?Q?Jean-Baptiste_Onofr=C3=A9_=28JIRA=29?= <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <JIRA.12858268.1440415486000.68290.1444394126645@Atlassian.JIRA>
In-Reply-To: <JIRA.12858268.1440415486000@Atlassian.JIRA>
References: <JIRA.12858268.1440415486000@Atlassian.JIRA>
 <JIRA.12858268.1440415486711@arcas>
Subject: [jira] [Commented] (KARAF-3955) Use of negative shell exit codes is
 not delux
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/KARAF-3955?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1495=
0313#comment-14950313 ]=20

Jean-Baptiste Onofr=C3=A9 commented on KARAF-3955:
---------------------------------------------

As existing scripts may depend to this exit code, I prefer to keep as it's.=
 More over, everything which is not 0 means an error, some negative values =
can be used.

Right now, Karaf main can return:
- -1 if the KARAF_DATA is not a directory or if the OSGi framework can be l=
aunched
- -2 if an error occurs while shutting down the OSGi framework (at exit)
- -3 if Karaf timed out waiting the OSGi framework to stop

> Use of negative shell exit codes is not delux
> ---------------------------------------------
>
>                 Key: KARAF-3955
>                 URL: https://issues.apache.org/jira/browse/KARAF-3955
>             Project: Karaf
>          Issue Type: Bug
>            Reporter: Benson Margulies
>            Assignee: Jean-Baptiste Onofr=C3=A9
>            Priority: Minor
>
> Main.java has a set of calls like: System.exit(-1);.
> EXIT_FAILURE is '1', not '-1', and in general negative values aren't nece=
ssary, since the definition of 'oops' is 'not 0'. I propose that these be a=
djusted.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)