karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré (JIRA) <j...@apache.org>
Subject [jira] [Commented] (KARAF-3955) Use of negative shell exit codes is not delux
Date Fri, 09 Oct 2015 12:35:26 GMT

    [ https://issues.apache.org/jira/browse/KARAF-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950313#comment-14950313
] 

Jean-Baptiste Onofré commented on KARAF-3955:
---------------------------------------------

As existing scripts may depend to this exit code, I prefer to keep as it's. More over, everything
which is not 0 means an error, some negative values can be used.

Right now, Karaf main can return:
- -1 if the KARAF_DATA is not a directory or if the OSGi framework can be launched
- -2 if an error occurs while shutting down the OSGi framework (at exit)
- -3 if Karaf timed out waiting the OSGi framework to stop

> Use of negative shell exit codes is not delux
> ---------------------------------------------
>
>                 Key: KARAF-3955
>                 URL: https://issues.apache.org/jira/browse/KARAF-3955
>             Project: Karaf
>          Issue Type: Bug
>            Reporter: Benson Margulies
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>
> Main.java has a set of calls like: System.exit(-1);.
> EXIT_FAILURE is '1', not '-1', and in general negative values aren't necessary, since
the definition of 'oops' is 'not 0'. I propose that these be adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message