karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan-Peter Nilsson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-3656) SSH message channel closed too early
Date Mon, 06 Jul 2015 23:21:04 GMT

    [ https://issues.apache.org/jira/browse/KARAF-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615865#comment-14615865

Jan-Peter Nilsson commented on KARAF-3656:

This seems to be a separate issue introduced by some other change in 3.0.4, I tried reverting
this change and it does not change the behavior.

(The issue you are seeing is that something expects a closeSession(CommandSessionImpl) method
in org.apache.felix.gogo.runtime.CommandProcessorImpl under shell/console, but there is no
such method, adding it makes the ssh from ant successful)

> SSH message channel closed too early
> ------------------------------------
>                 Key: KARAF-3656
>                 URL: https://issues.apache.org/jira/browse/KARAF-3656
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-shell
>    Affects Versions: 3.0.3, 2.4.1, 2.3.10, 4.0.0.M2
>            Reporter: Jan-Peter Nilsson
>            Assignee: Guillaume Nodet
>            Priority: Minor
>             Fix For: 2.4.2, 3.0.4, 2.3.12, 4.0.0.M3
>         Attachments: 0001-KARAF-3656-Spawn-a-new-thread-for-ShellCommand.start.patch
> Using SSH exec with Karaf 2.3.10 SSH_MSG_CHANNEL_SUCCESS is sent after SSH_MSG_CHANNEL_CLOSE
in the response.
> This causes problems when trying to use the Paramiko SSH client library as it will close
the channel on receiving SSH_MSG_CHANNEL_CLOSE and considers it a failure if SSH_MSG_CHANNEL_SUCCESS
was not received.
> {code:title=reproduce.py|borderStyle=solid}
> #!/usr/bin/python
> import paramiko
> client = paramiko.SSHClient()
> client.set_missing_host_key_policy(paramiko.AutoAddPolicy())
> client.load_system_host_keys()
> client.connect('localhost', port=8101, username="karaf", password="karaf")
> client.exec_command('help')
> # Throws SSHException "Channel closed." for affected versions.
> {code}
> The reason SUCCESS and CLOSE come out of order seems to be that start in the ShellCommand
class does not spawn a separate thread but calls the onExit callback from within the same
thread, see [SSHD-295|https://issues.apache.org/jira/browse/SSHD-295] and the [Apache MINA
SSHD API|http://mina.apache.org/sshd-project/apidocs/org/apache/sshd/server/Command.html#start-org.apache.sshd.server.Environment-].

This message was sent by Atlassian JIRA

View raw message