karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Schulz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-2984) Improve setenv script to include placeholder for extra java options
Date Mon, 15 Dec 2014 13:37:13 GMT

    [ https://issues.apache.org/jira/browse/KARAF-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246647#comment-14246647
] 

Matthias Schulz commented on KARAF-2984:
----------------------------------------

Seems like the client.bat is broken since the JAVA_OPTS is constructed that way:

if "%EXTRA_JAVA_OPTS%" == "" goto :KARAF_EXTRA_JAVA_OPTS_END
    set JAVA_OPTS="%JAVA_OPTS% %EXTRA_JAVA_OPTS%"
:KARAF_EXTRA_JAVA_OPTS_END

pay attention to the surrounding quotation marks. They will break the command line execution.
The karaf.bat doesn't use the quotation marks and it works.

The failure you'll notice is:
Error: Could not find or load main class  -XX:-<whatever you have entered as additional
java_opts>

Without the quotation marks, just like the karaf.bat, client.bat is working as expected.

> Improve setenv script to include placeholder for extra java options
> -------------------------------------------------------------------
>
>                 Key: KARAF-2984
>                 URL: https://issues.apache.org/jira/browse/KARAF-2984
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Jonathan Anstey
>            Assignee: Jonathan Anstey
>             Fix For: 2.4.0, 4.0.0, 3.0.2
>
>
> We have a really nice setenv script that lets you change default memory sizes etc. It
would be nice if we could add another variable here such as EXTRA_JAVA_OPTS that users could
set to easily pass in other options without having to edit the karaf script or copy the DEFAULT_JAVA_OPTS
from the karaf script.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message