Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3A7FA1169C for ; Sat, 13 Sep 2014 06:38:34 +0000 (UTC) Received: (qmail 93047 invoked by uid 500); 13 Sep 2014 06:38:33 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 93019 invoked by uid 500); 13 Sep 2014 06:38:33 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 93008 invoked by uid 99); 13 Sep 2014 06:38:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Sep 2014 06:38:33 +0000 Date: Sat, 13 Sep 2014 06:38:33 +0000 (UTC) From: =?utf-8?Q?Jean-Baptiste_Onofr=C3=A9_=28JIRA=29?= To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-3210) karaf:features-generate-descriptor fails with Maven 3.1.x and 3.2.x : required class was missing ... org/sonatype/aether/RepositorySystem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-3210?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1413= 2574#comment-14132574 ]=20 Jean-Baptiste Onofr=C3=A9 commented on KARAF-3210: --------------------------------------------- Fixed on karaf-3.0.x: https://git-wip-us.apache.org/repos/asf?p=3Dkaraf.git= ;a=3Dcommitdiff;h=3D4de411e3ec06c9fae7fed04a22d955b5925d4705 > karaf:features-generate-descriptor fails with Maven 3.1.x and 3.2.x : req= uired class was missing ... org/sonatype/aether/RepositorySystem > -------------------------------------------------------------------------= ---------------------------------------------------------------- > > Key: KARAF-3210 > URL: https://issues.apache.org/jira/browse/KARAF-3210 > Project: Karaf > Issue Type: Bug > Components: karaf-tooling > Reporter: Stuart McCulloch > Assignee: Jean-Baptiste Onofr=C3=A9 > Fix For: 4.0.0, 3.0.2 > > > Appears to be a regression that affects the latest 3.0.x and master branc= hes. Note this is subtly different to KARAF-2395 which was an exception due= to a missing component whereas this an exception due to a missing/hidden c= lass. > Switching over to the {{hasComponent(String)}} method solves the problem: > {code} > diff --git a/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/to= oling/features/DependencyHelperFactory.java b/tooling/karaf-maven-plugin/sr= c/main/java/org/apache/karaf/tooling/features/DependencyHelperFactory.java > index f054c6c..1287dc8 100644 > --- a/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/f= eatures/DependencyHelperFactory.java > +++ b/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/f= eatures/DependencyHelperFactory.java > @@ -51,12 +51,12 @@ public class DependencyHelperFactory { > */ > public static DependencyHelper createDependencyHelper(PlexusContaine= r container, MavenProject mavenProject, MavenSession mavenSession, Log log)= throws MojoExecutionException { > try { > - if (container.hasComponent(org.sonatype.aether.RepositorySys= tem.class)) { > + if (container.hasComponent("org.sonatype.aether.RepositorySy= stem")) { > org.sonatype.aether.RepositorySystem system =3D containe= r.lookup(org.sonatype.aether.RepositorySystem.class); > org.sonatype.aether.RepositorySystemSession session =3D = mavenSession.getRepositorySession(); > List repositories =3D mavenProject.get= RemoteProjectRepositories(); > return new Dependency30Helper(repositories, session, sys= tem); > - } else if (container.hasComponent(org.eclipse.aether.Reposit= orySystem.class)) { > + } else if (container.hasComponent("org.eclipse.aether.Reposi= torySystem")) { > org.eclipse.aether.RepositorySystem system =3D container= .lookup(org.eclipse.aether.RepositorySystem.class); > Object session; > try { > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)